Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): improve path separator detection on Windows #888

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

ayooh
Copy link
Contributor

@ayooh ayooh commented Apr 17, 2024

If you use neovim binary from MSYS2 packages, the vim.loop.os_uname() output will be like this:

{
  machine = "x86_64",
  release = "10.0.22631",
  sysname = "MINGW32_NT-10.0",
  version = "Windows 11 Pro"
}

sysname will not start with “Windows”, even if you're on Windows. This will break the duplicate prefix feature.

This PR uses a common method to detect Windows.

Copy link
Owner

@akinsho akinsho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks 👍🏾

@akinsho akinsho merged commit d7ebc0d into akinsho:main Apr 19, 2024
1 check passed
sstallion pushed a commit to sstallion/bufferline.nvim that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants