feat(ui): Tab Renaming #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
muhmud
commented
Jan 4, 2024
muhmud
commented
- Ported over changes from previous PR
|
Hey @akinsho , I think this is pretty much ready to look at. Quick question: how do I run the tests? |
akinsho
reviewed
Jan 8, 2024
Co-authored-by: Akin <[email protected]>
Co-authored-by: Akin <[email protected]>
akinsho
reviewed
Jan 22, 2024
lua/bufferline/tabpages.lua
Outdated
| name = string(tabnr) | ||
| end | ||
| api.nvim_tabpage_set_var(tabnr, "name", name) | ||
| M.get() |
There was a problem hiding this comment.
I just noticed this before merging? why does this function need to be called? is this trying to force a refresh? There is a ui.refresh function for that if so
There was a problem hiding this comment.
I'm assuming my original reasoning was because it was a more tab scoped re-render call? If ui.refresh will work fine, though, then that'd make more sense.
There was a problem hiding this comment.
I'll make this change & test it out
There was a problem hiding this comment.
Pushed a commit for this & tested it out; looks like it's working
sstallion
pushed a commit
to sstallion/bufferline.nvim
that referenced
this pull request
Jul 3, 2024
* ported over changes from previous pr * Update lua/bufferline/commands.lua Co-authored-by: Akin <[email protected]> * Update lua/bufferline/tabpages.lua Co-authored-by: Akin <[email protected]> * change to use ui.refresh --------- Co-authored-by: Muhmud Ahmad <[email protected]> Co-authored-by: Akin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.