Ignore disabled diagnostics #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinsho
requested changes
Sep 18, 2023
There was a problem hiding this comment.
@sidequestboy this looks good to me but the method you are using is_disabled was only added in nvim v0.9.0 so if I merge this anyone on an older version of neovim will have issues. Can you add a check here to ensure that that method exists before using it, if not don't use it.
akinsho
reviewed
Sep 19, 2023
lua/bufferline/diagnostics.lua
Outdated
| @@ -70,8 +70,10 @@ local get_diagnostics = { | |||
| nvim_lsp = function() | |||
| local results = {} | |||
| local diagnostics = vim.diagnostic.get() | |||
| -- is_disabled introduced in 0.9 | |||
| local is_new_nvim = fn.has("nvim-0.9") > 0 | |||
There was a problem hiding this comment.
@sidequestboy I think this can be simplified and made more robust by just checking that the function exists. This is what I do elsewhere e.g.
if vim.diagnostic.is_disabled ~= nil rather than checking for the specific version. Also would be good to have a TODO comment for the future so I can come in and remove this eventually 🙏🏾
|
thanks for catching that, lmk if this looks good |
akinsho
approved these changes
Sep 20, 2023
sstallion
pushed a commit
to sstallion/bufferline.nvim
that referenced
this pull request
Jul 3, 2024
* Ignore disabled diagnostics * Add nil check to vim.diagnostic.is_disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.