add support for pg-promise target #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks! Could you also add the |
|
@akheron done :) Please let me know if I missed anything else |
akheron
requested changes
Sep 13, 2021
akheron
approved these changes
Sep 13, 2021
|
Great, merged! 💎 |
|
Awesome, thank you! It'd be appreciated if you could create a new release whenever you get the chance. For now I'm just running my fork locally so no pressure. Thank you for your quick reviews! |
|
Released in v1.3.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for generating with
pg-promiseas the target. Despite being backed bypg, the APIs and types are slightly different. For example, there is noClientBaseorPooltypes; all query functions are located directly on the database instance type itself.In order to test this, I ran it against some SQL queries in an (unfortunately private) repo I work in and have validated that it produces usable output. I'm happy to add additional tests if necessary or desired.