distributedOmit with prop tests. did not work for pick so skipping #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hm although this fixed some cases for me, i still cant use the library, the .at(n) for an array of T where T is a discriminated union breaks in both the standalone and regular apis, even if i perform the identity during the modification. will give up and use immer for now, appreciate it nonetheless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #421
u may like to organize this differently and i didnt look into why distributedOmit didnt work for pick, but as i dont use that and really want to use your library but need it to preserve unions for prop() (which returns Omit that breaks unions see #421 ), i built a fix and a type test for it
i looked at effect ts and monocle and had different issues with each, yours seems the most ergonomic and i like the standalone api since i can compose things together independently of the parent types allowing me to avoid repetitive optics
but i need it to work with my unions or i cant use it. about to try incorporating this fork into my app and see how that goes and if i run into any other challenges
really hoping to find a reliable and simple optics capability for typescript
thanks for all the work u put into this