Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akeneo 3.2 to 4.0 documentation suggests rector version that doesn't work anymore #1555

Open
lgoebkes opened this issue Jan 21, 2021 · 0 comments

Comments

@lgoebkes
Copy link

In the documentation for migrating from 3.2 to 4.0 it is suggested to install rector with:
composer require --dev rector/rector

Currently it tries to install a version that clashes with other dependencies of symfony.
I changed it locally to rector/rector-prefixed which installs but has no scan-fatal-errors command and can not work with the supplied rector.yml configuration anymore.

Easy fix is to use:
composer require rector/rector-prefixed:^0.6.0

This version contains the mentioned command and allows the usage of the provided rector.yml.

I could open a PR for it if it helps.

Maybe you want to go another route:
Probably it would be better to update the configuration file to the new php version and use the new rector --dry-run instead of scan-fatal-errors command but this would be done in another repository, am I right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant