Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service_manage = false breaks refresh on config or resource changes #128

Open
ThomasLohner opened this issue Feb 14, 2019 · 0 comments · May be fixed by #129
Open

service_manage = false breaks refresh on config or resource changes #128

ThomasLohner opened this issue Feb 14, 2019 · 0 comments · May be fixed by #129

Comments

@ThomasLohner
Copy link

We are running supervisor in Docker containers. In this scenario supervisor can't be run as a daemon but instead runs in foreground. So we are setting supervisord::service_manage: false.

With this param set there will be no refresh at all on changes to config or supervisord::program-resources. That's because of this condition in reload.pp:

if $::supervisord::service_manage {
 ...
}

In my opinion applying config or resources is a completely different thing than deciding how you want to run supervisor. I will submit a PR with simply removing the if. I'm also happy to hear your opinion on this.

@ThomasLohner ThomasLohner linked a pull request Feb 14, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant