Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid substitutions when Webpack was introduced #4476

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

w89612b
Copy link
Contributor

@w89612b w89612b commented Apr 14, 2021

Avoid 'require' being replaced with Webpack's unique declaration 'non_webpack_require' when Webpack introduces packaging

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Avoid 'require' being replaced with Webpack's unique declaration '__non_webpack_require__' when Webpack introduces packaging
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #4476 (0af8b48) into master (554831e) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4476   +/-   ##
=======================================
  Coverage   70.55%   70.55%           
=======================================
  Files         543      543           
  Lines       54238    54238           
  Branches    10186    10186           
=======================================
  Hits        38268    38268           
  Misses      15970    15970           
Flag Coverage Δ
unittests 70.55% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ace/worker/worker.js 50.00% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 554831e...0af8b48. Read the comment docs.

To deal with warning
@andrewnester andrewnester merged commit a540323 into ajaxorg:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants