Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sushy-tools image #10

Open
mattmceuen opened this issue Jun 16, 2021 · 3 comments
Open

Pin sushy-tools image #10

mattmceuen opened this issue Jun 16, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request size s
Milestone

Comments

@mattmceuen
Copy link
Contributor

Today, vino (as well as airship-in-a-pod) make use of the quay.io/metal3-io/sushy-tools image, which unfortunately does not get tagged aside from latest. This is problematic, and could lead to unexpected/untested behavior.

This issue is to pin to a particular SHA value of the image (the most recent one, unless there's reason not to). A comment should be left above the image spec that notes down the date that corresponds to the SHA.

The same SHA/comment should be added to the Treasuremap versions yaml as part of this story as well.

@mattmceuen mattmceuen added enhancement New feature or request triage labels Jun 16, 2021
@eak13 eak13 added this to the v2.2 milestone Jun 17, 2021
@jezogwza jezogwza removed the triage label Jun 23, 2021
@sshiba
Copy link

sshiba commented Jul 2, 2021

Please, assign this issue to me. Thanks.

@sshiba
Copy link

sshiba commented Jul 2, 2021

Two patchsets created to address this issue:

@sshiba
Copy link

sshiba commented Jul 6, 2021

Vino: https://review.opendev.org/c/airship/vino/+/799326 passed +1 Zull and is ready for review.
Treasuremap: https://review.opendev.org/c/airship/treasuremap/+/799325 failed Zull so rechecked.

@lb4368 lb4368 added the size s label Jul 12, 2021
@lb4368 lb4368 modified the milestones: v2.2, Future Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size s
Projects
None yet
Development

No branches or pull requests

5 participants