Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Zendesk Support: add new stream User Identities #47939

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

wmcguinn-octave
Copy link
Contributor

@wmcguinn-octave wmcguinn-octave commented Oct 29, 2024

What

Add new stream to Zendesk Support connector for User Identities

How

Creates a new class UserIdentities which inherits from Users and uses Zendesk's side-loading to add additional data to the Users endpoint.

Review guide

  1. streams.py
  2. source.py

User Impact

  • What is the end result perceived by the user?
    • There will be a new stream available
  • If there are negative side effects, please list them.
    • None

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Oct 29, 2024

@wmcguinn-octave is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@wmcguinn-octave
Copy link
Contributor Author

@aldogonzalez8 I see you approved a Zendesk Support PR a few weeks ago, any chance I can get a review on this one?

@aldogonzalez8
Copy link
Contributor

@aldogonzalez8 I see you approved a Zendesk Support PR a few weeks ago, any chance I can get a review on this one?

I will review it.

@aldogonzalez8
Copy link
Contributor

@wmcguinn-octave I think this looks good, I was able to run a read for this new stream, would you mind doing next?

  • Fix conflicts
  • Add the following records to the expected records file, I picked those from the results in our testing account, it should make pass the test that is failing:
    airbyte-integrations/connectors/source-zendesk-support/integration_tests/expected_records.jsonl
{"type":"RECORD","record":{"stream":"user_identities","data":{"url":"https://d3v-airbyte.zendesk.com/api/v2/users/6128164851599/identities/6128164851983.json","id":6128164851983,"user_id":6128164851599,"type":"email","value":"[email protected]","verified":false,"primary":true,"created_at":"2022-12-29T08:56:24Z","updated_at":"2022-12-29T08:56:24Z","undeliverable_count":0,"deliverable_state":"deliverable"},"emitted_at":1732395279590}}
{"type":"RECORD","record":{"stream":"user_identities","data":{"url":"https://d3v-airbyte.zendesk.com/api/v2/users/6128155777039/identities/6128172776719.json","id":6128172776719,"user_id":6128155777039,"type":"email","value":"[email protected]","verified":false,"primary":true,"created_at":"2022-12-29T08:56:24Z","updated_at":"2022-12-29T08:56:24Z","undeliverable_count":0,"deliverable_state":"deliverable"},"emitted_at":1732395279591}}
{"type":"RECORD","record":{"stream":"user_identities","data":{"url":"https://d3v-airbyte.zendesk.com/api/v2/users/6128112893967/identities/6128135313551.json","id":6128135313551,"user_id":6128112893967,"type":"email","value":"[email protected]","verified":false,"primary":true,"created_at":"2022-12-29T08:56:24Z","updated_at":"2022-12-29T08:56:24Z","undeliverable_count":0,"deliverable_state":"deliverable"},"emitted_at":1732395279591}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/zendesk-support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants