-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🐛 Destination Oracle: maxStringLength should be 128 (#6611)
* revert back to 128 characters in OracleNameTransformer | Create Custom OracleContainer * update to 0.1.9 Co-authored-by: vmaltsev <[email protected]>
- Loading branch information
1 parent
00b43df
commit 6e53a57
Showing
8 changed files
with
209 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
199 changes: 199 additions & 0 deletions
199
...src/test-integration/java/io/airbyte/integrations/destination/oracle/OracleContainer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,199 @@ | ||
| /* | ||
| * Copyright (c) 2021 Airbyte, Inc., all rights reserved. | ||
| */ | ||
|
|
||
| package io.airbyte.integrations.destination.oracle; | ||
|
|
||
| import static java.time.temporal.ChronoUnit.SECONDS; | ||
| import static java.util.Collections.singleton; | ||
|
|
||
| import java.time.Duration; | ||
| import java.util.Arrays; | ||
| import java.util.List; | ||
| import java.util.Set; | ||
| import java.util.concurrent.Future; | ||
| import org.apache.commons.lang3.StringUtils; | ||
| import org.testcontainers.containers.JdbcDatabaseContainer; | ||
| import org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy; | ||
| import org.testcontainers.utility.DockerImageName; | ||
|
|
||
| public class OracleContainer extends JdbcDatabaseContainer<OracleContainer> { | ||
|
|
||
| public static final String NAME = "oracle"; | ||
| private static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse("gvenzl/oracle-xe"); | ||
|
|
||
| static final String DEFAULT_TAG = "18.4.0-slim"; | ||
| static final String IMAGE = DEFAULT_IMAGE_NAME.getUnversionedPart(); | ||
|
|
||
| private static final int ORACLE_PORT = 1521; | ||
| private static final int APEX_HTTP_PORT = 8080; | ||
|
|
||
| private static final int DEFAULT_STARTUP_TIMEOUT_SECONDS = 240; | ||
| private static final int DEFAULT_CONNECT_TIMEOUT_SECONDS = 120; | ||
|
|
||
| // Container defaults | ||
| static final String DEFAULT_DATABASE_NAME = "xepdb1"; | ||
| static final String DEFAULT_SID = "xe"; | ||
| static final String DEFAULT_SYSTEM_USER = "system"; | ||
| static final String DEFAULT_SYS_USER = "sys"; | ||
|
|
||
| // Test container defaults | ||
| static final String APP_USER = "test"; | ||
| static final String APP_USER_PASSWORD = "test"; | ||
|
|
||
| // Restricted user and database names | ||
| private static final List<String> ORACLE_SYSTEM_USERS = Arrays.asList(DEFAULT_SYSTEM_USER, DEFAULT_SYS_USER); | ||
|
|
||
| private String databaseName = DEFAULT_DATABASE_NAME; | ||
| private String username = APP_USER; | ||
| private String password = APP_USER_PASSWORD; | ||
| private boolean usingSid = false; | ||
|
|
||
| public OracleContainer() { | ||
| this(DEFAULT_IMAGE_NAME.withTag(DEFAULT_TAG)); | ||
| } | ||
|
|
||
| public OracleContainer(String dockerImageName) { | ||
| this(DockerImageName.parse(dockerImageName)); | ||
| } | ||
|
|
||
| public OracleContainer(final DockerImageName dockerImageName) { | ||
| super(dockerImageName); | ||
| dockerImageName.assertCompatibleWith(DEFAULT_IMAGE_NAME); | ||
| preconfigure(); | ||
| } | ||
|
|
||
| public OracleContainer(Future<String> dockerImageName) { | ||
| super(dockerImageName); | ||
| preconfigure(); | ||
| } | ||
|
|
||
| private void preconfigure() { | ||
| this.waitStrategy = new LogMessageWaitStrategy() | ||
| .withRegEx(".*DATABASE IS READY TO USE!.*\\s") | ||
| .withTimes(1) | ||
| .withStartupTimeout(Duration.of(DEFAULT_STARTUP_TIMEOUT_SECONDS, SECONDS)); | ||
|
|
||
| withConnectTimeoutSeconds(DEFAULT_CONNECT_TIMEOUT_SECONDS); | ||
| addExposedPorts(ORACLE_PORT, APEX_HTTP_PORT); | ||
| } | ||
|
|
||
| @Override | ||
| protected void waitUntilContainerStarted() { | ||
| getWaitStrategy().waitUntilReady(this); | ||
| } | ||
|
|
||
| @Override | ||
| public Set<Integer> getLivenessCheckPortNumbers() { | ||
| return singleton(getMappedPort(ORACLE_PORT)); | ||
| } | ||
|
|
||
| @Override | ||
| public String getDriverClassName() { | ||
| return "oracle.jdbc.OracleDriver"; | ||
| } | ||
|
|
||
| @Override | ||
| public String getJdbcUrl() { | ||
| return isUsingSid() ? "jdbc:oracle:thin:" + "@" + getHost() + ":" + getOraclePort() + ":" + getSid() | ||
| : "jdbc:oracle:thin:" + "@" + getHost() + ":" + getOraclePort() + "/" + getDatabaseName(); | ||
| } | ||
|
|
||
| @Override | ||
| public String getUsername() { | ||
| // An application user is tied to the database, and therefore not authenticated to connect to SID. | ||
| return isUsingSid() ? DEFAULT_SYSTEM_USER : username; | ||
| } | ||
|
|
||
| @Override | ||
| public String getPassword() { | ||
| return password; | ||
| } | ||
|
|
||
| @Override | ||
| public String getDatabaseName() { | ||
| return databaseName; | ||
| } | ||
|
|
||
| protected boolean isUsingSid() { | ||
| return usingSid; | ||
| } | ||
|
|
||
| @Override | ||
| public OracleContainer withUsername(String username) { | ||
| if (StringUtils.isEmpty(username)) { | ||
| throw new IllegalArgumentException("Username cannot be null or empty"); | ||
| } | ||
| if (ORACLE_SYSTEM_USERS.contains(username.toLowerCase())) { | ||
| throw new IllegalArgumentException("Username cannot be one of " + ORACLE_SYSTEM_USERS); | ||
| } | ||
| this.username = username; | ||
| return self(); | ||
| } | ||
|
|
||
| @Override | ||
| public OracleContainer withPassword(String password) { | ||
| if (StringUtils.isEmpty(password)) { | ||
| throw new IllegalArgumentException("Password cannot be null or empty"); | ||
| } | ||
| this.password = password; | ||
| return self(); | ||
| } | ||
|
|
||
| @Override | ||
| public OracleContainer withDatabaseName(String databaseName) { | ||
| if (StringUtils.isEmpty(databaseName)) { | ||
| throw new IllegalArgumentException("Database name cannot be null or empty"); | ||
| } | ||
|
|
||
| if (DEFAULT_DATABASE_NAME.equals(databaseName.toLowerCase())) { | ||
| throw new IllegalArgumentException("Database name cannot be set to " + DEFAULT_DATABASE_NAME); | ||
| } | ||
|
|
||
| this.databaseName = databaseName; | ||
| return self(); | ||
| } | ||
|
|
||
| public OracleContainer usingSid() { | ||
| this.usingSid = true; | ||
| return self(); | ||
| } | ||
|
|
||
| @Override | ||
| public OracleContainer withUrlParam(String paramName, String paramValue) { | ||
| throw new UnsupportedOperationException("The Oracle Database driver does not support this"); | ||
| } | ||
|
|
||
| @SuppressWarnings("SameReturnValue") | ||
| public String getSid() { | ||
| return DEFAULT_SID; | ||
| } | ||
|
|
||
| public Integer getOraclePort() { | ||
| return getMappedPort(ORACLE_PORT); | ||
| } | ||
|
|
||
| @SuppressWarnings("unused") | ||
| public Integer getWebPort() { | ||
| return getMappedPort(APEX_HTTP_PORT); | ||
| } | ||
|
|
||
| @Override | ||
| public String getTestQueryString() { | ||
| return "SELECT 1 FROM DUAL"; | ||
| } | ||
|
|
||
| @Override | ||
| protected void configure() { | ||
| withEnv("ORACLE_PASSWORD", password); | ||
|
|
||
| // Only set ORACLE_DATABASE if different than the default. | ||
| if (databaseName != DEFAULT_DATABASE_NAME) { | ||
| withEnv("ORACLE_DATABASE", databaseName); | ||
| } | ||
|
|
||
| withEnv("APP_USER", username); | ||
| withEnv("APP_USER_PASSWORD", password); | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters