Destination redshift: Remove encrypted staging option (#39141)

Author: edgao

airbyte-integrations/connectors/destination-redshift/metadata.yaml

@@ -5,7 +5,7 @@ data:
   connectorSubtype: database
   connectorType: destination
   definitionId: f7a7d195-377f-cf5b-70a5-be6b819019dc
-  dockerImageTag: 3.0.0
+  dockerImageTag: 3.1.0
   dockerRepository: airbyte/destination-redshift
   documentationUrl: https://docs.airbyte.com/integrations/destinations/redshift
   githubIssueLabel: destination-redshift

airbyte-integrations/connectors/destination-redshift/src/main/kotlin/io/airbyte/integrations/destination/redshift/operations/RedshiftS3StagingSqlOperations.kt

@@ -141,6 +141,9 @@ class RedshiftS3StagingSqlOperations(
             if (keyEncryptingKey == null) {
                 ""
             } else {
+                // TODO This is broken (it's using Snowflake SQL syntax).
+                // Leaving it here since the rest of the plumbing seems reasonable,
+                // but we should fix this eventually.
                 String.format(
                     " encryption = (type = 'aws_cse' master_key = '%s')",
                     BASE64_ENCODER.encodeToString(keyEncryptingKey)

airbyte-integrations/connectors/destination-redshift/src/main/resources/spec.json

@@ -180,49 +180,6 @@
                 "description": "Whether to delete the staging files from S3 after completing the sync. See <a href=\"https://docs.airbyte.com/integrations/destinations/redshift/#:~:text=the%20root%20directory.-,Purge%20Staging%20Data,-Whether%20to%20delete\"> docs</a> for details.",
                 "default": true,
                 "order": 6
-              },
-              "encryption": {
-                "title": "Encryption",
-                "type": "object",
-                "description": "How to encrypt the staging data",
-                "default": { "encryption_type": "none" },
-                "oneOf": [
-                  {
-                    "title": "No encryption",
-                    "description": "Staging data will be stored in plaintext.",
-                    "type": "object",
-                    "required": ["encryption_type"],
-                    "properties": {
-                      "encryption_type": {
-                        "type": "string",
-                        "const": "none",
-                        "enum": ["none"],
-                        "default": "none"
-                      }
-                    }
-                  },
-                  {
-                    "title": "AES-CBC envelope encryption",
-                    "description": "Staging data will be encrypted using AES-CBC envelope encryption.",
-                    "type": "object",
-                    "required": ["encryption_type"],
-                    "properties": {
-                      "encryption_type": {
-                        "type": "string",
-                        "const": "aes_cbc_envelope",
-                        "enum": ["aes_cbc_envelope"],
-                        "default": "aes_cbc_envelope"
-                      },
-                      "key_encrypting_key": {
-                        "type": "string",
-                        "title": "Key",
-                        "description": "The key, base64-encoded. Must be either 128, 192, or 256 bits. Leave blank to have Airbyte generate an ephemeral key for each sync.",
-                        "airbyte_secret": true
-                      }
-                    }
-                  }
-                ],
-                "order": 7
               }
             }
           }

docs/integrations/destinations/redshift.md

@@ -244,6 +244,7 @@ Each stream will be output into its own raw table in Redshift. Each table will c
 
 | Version | Date       | Pull Request                                               | Subject                                                                                                                                                                                                          |
 |:--------|:-----------|:-----------------------------------------------------------|:-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| 3.1.0   | 2024-06-26 | [39141](https://github.com/airbytehq/airbyte/pull/39141)   | Remove nonfunctional "encrypted staging" option                                                                                                                                                                  |
 | 3.0.0   | 2024-06-04 | [38886](https://github.com/airbytehq/airbyte/pull/38886)   | Remove standard inserts mode                                                                                                                                                                                     |
 | 2.6.4   | 2024-05-31 | [38825](https://github.com/airbytehq/airbyte/pull/38825)   | Adopt CDK 0.35.15                                                                                                                                                                                                |
 | 2.6.3   | 2024-05-31 | [38803](https://github.com/airbytehq/airbyte/pull/38803)   | Source auto-conversion to Kotlin                                                                                                                                                                                 |
@@ -352,4 +353,4 @@ Each stream will be output into its own raw table in Redshift. Each table will c
 | 0.3.12  | 2021-07-21 | [\#3555](https://github.com/airbytehq/airbyte/pull/3555)   | Enable partial checkpointing for halfway syncs                                                                                                                                                                   |
 | 0.3.11  | 2021-07-20 | [\#4874](https://github.com/airbytehq/airbyte/pull/4874)   | allow `additionalProperties` in connector spec                                                                                                                                                                   |
 
-</details>
+</details>