feat: add version with dataclasses #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem1205
changed the title
girarda
approved these changes
Aug 23, 2024
| "Topic :: Scientific/Engineering", | ||
| "Topic :: Software Development :: Libraries :: Python Modules", | ||
| "License :: OSI Approved :: MIT License", | ||
| # Python Version Support |
| --input "$ROOT_DIR/$YAML_DIR/$filename_wo_ext.yaml" \ | ||
| --output "$ROOT_DIR/$OUTPUT_DIR/$filename_wo_ext.py" \ | ||
| --output-model-type dataclasses.dataclass \ | ||
| --target-python-version 3.10 \ |
There was a problem hiding this comment.
should we target 3.8 since that's the minimum version?
There was a problem hiding this comment.
Leave 3.8 support sincee 3.8 and 3.10 version are identical.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Follow up airbytehq/airbyte#44026
Generate another version of the python protocol, by generating dataclasses instead of
pydantic.v2BaseModel.Resolving https://github.com/airbytehq/airbyte-internal-issues/issues/8945
Reason: increase python CDK performance in airbytehq/airbyte#44026
Note
Dataclass version will have different package name :
airbyte_protocol_dataclasses, so we can import bothpydanticanddataclassesversions at the same timeHow
Use
datamodel-codegento create the models from jsonschema, with flag--output-model-type dataclasses.dataclass