Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix publish for python classes calling wrong docker script #83

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Jun 17, 2024

Fixes publish failure here: https://github.com/airbytehq/airbyte-protocol/actions/runs/9554386529/job/26335309424

Also adds gradle stuff to generate it via gradle, though i think its pretty unused

@erohmensing erohmensing requested a review from natikgadzhi June 17, 2024 21:27
Copy link

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work?

@@ -19,7 +19,7 @@ pip install -U datamodel_code_generator
rm -rf "$ROOT_DIR/$OUTPUT_DIR"/*.py
mkdir -p "$ROOT_DIR/$OUTPUT_DIR"

echo "# generated by generate-python-classes" > "$ROOT_DIR/$OUTPUT_DIR"/__init__.py
echo "# generated by generate-python-pydantic-v2" > "$ROOT_DIR/$OUTPUT_DIR"/__init__.py

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo "# generated by generate-python-pydantic-v2" > "$ROOT_DIR/$OUTPUT_DIR"/__init__.py
echo "# generated by generate-python-pydantic-v2.sh" > "$ROOT_DIR/$OUTPUT_DIR"/__init__.py

@erohmensing erohmensing merged commit 2a92e61 into main Jun 18, 2024
7 checks passed
@erohmensing erohmensing deleted the ella/fixbuild branch June 18, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants