Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add transient_error as new failure type #69

Merged
merged 1 commit into from
Mar 19, 2024
Merged

feat: add transient_error as new failure type #69

merged 1 commit into from
Mar 19, 2024

Conversation

malikdiarra
Copy link
Contributor

@malikdiarra malikdiarra commented Mar 18, 2024 •
edited
Loading

@malikdiarra malikdiarra requested a review from brianjlai March 18, 2024 16:30
@malikdiarra malikdiarra changed the title Add transient error as new failure type feat: add transient_error as new failure type Mar 18, 2024
brianjlai
brianjlai approved these changes Mar 18, 2024
View reviewed changes
Copy link

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick question. From the platform error handling side, are transient errors going to be raised to Sentry?

@malikdiarra
Copy link
Contributor Author

One quick question. From the platform error handling side, are transient errors going to be raised to Sentry?

Right now, they will. We can discuss what behavior we want in those cases during our stand up

@malikdiarra malikdiarra merged commit 8fada32 into main Mar 19, 2024
6 of 7 checks passed
@malikdiarra malikdiarra deleted the malik/transient-failures branch March 19, 2024 20:31
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjlai brianjlai brianjlai approved these changes

@cgardens cgardens cgardens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malikdiarra @cgardens @brianjlai