fix: Skip dont error when invalid jsonSchemaNode is found during traversal #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related to https://github.com/airbytehq/oncall/issues/2703
The goal is to relax the hard requirement of the json node being an object.
Why?
The release of a new stripe catalog revealed that
Because of this we opted to change the behaviour of this diff to simply skip the node.
This then causes the diff to treat the field as a new field when it becomes valid
Alternatives considered
1. A migration of catalogs
We could have edited all catalogs and configured catalogs in the last two months for stripe but that was deemed to risky and didnt solve the root issue
2. Traverse the array instead of skip
We could make this so the diff treats the change from invalid type to valid as an update. But that makes less sense