Add implementation of S3Cache #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
approved these changes
Feb 4, 2017
superset/results_backends.py
Outdated
| value_file | ||
| ) | ||
| except Exception as e: | ||
| logging.warn('Exception while trying to get %s: %s', key, e) |
There was a problem hiding this comment.
let's logging.exception(e) to get the full stack trace
superset/results_backends.py
Outdated
| } | ||
| ) | ||
| except Exception as e: | ||
| logging.warn('Exception while trying to delete %s: %s', key, e) |
superset/assets/version_info.json
Outdated
| {"GIT_SHA": "1e94498d9d548cbea6466a45dafa3b919c65bd1f", "version": "0.15.4"} |
There was a problem hiding this comment.
we should git rm --cached this file and add it to the .gitignore list... (my bad)
There was a problem hiding this comment.
Deleted it. It's already in the gitignore list, so hopefully it won't come back in the future.
|
LGTM |
added 5 commits
February 3, 2017 21:27
|
@yolken, do we have the option of saving result set in superset to S3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @mistercrunch
Content
This change implements an
S3Cachewhich extends fromwerkzeug.contrib.cache.BaseCache. All S3 calls are made using theboto3library.