Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] update test framework for 1:1 testing of rules to events #1293

Open
ryandeivert opened this issue Sep 19, 2020 · 0 comments
Open

[RFC] update test framework for 1:1 testing of rules to events #1293

ryandeivert opened this issue Sep 19, 2020 · 0 comments

Comments

@ryandeivert
Copy link
Contributor

Background

Having integration tests that designate more than one trigger_rules can make adding new integration tests annoyingly complicated. For instance, if a new test file is added that inadvertently triggers a rule that the user is not expecting it to trigger, they either need to add the other rule to the trigger_rules list or hack the test event to not trigger the other rule(s).

Steps to Reproduce

Add any test event that could trigger multiple rules and leave the other rules out of the trigger_rules list.

Desired Change

Devise mechanism to map test events directly to one rule only. Deprecate the usage of trigger_rules in favor of something .. simpler (?). Potentially implement this as rules and not_rules.. where not_rules would be an explicit list of rule the test event should not trigger (to test false positives)

@ryandeivert ryandeivert changed the title [RFC] update test framework foor 1:1 testing [RFC] update test framework for 1:1 testing of rules to events Sep 19, 2020
@ryandeivert ryandeivert added this to the 4.0.0 milestone Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant