Disable hover when DatePicker does not have focus #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
requested changes
May 3, 2017
| @@ -642,7 +642,8 @@ export default class DayPickerRangeController extends React.Component { | |||
|
|
|||
| isHovered(day) { | |||
| const { hoverDate } = this.state || {}; | |||
| return isSameDay(day, hoverDate); | |||
| const { focusedInput } = this.props; | |||
| return focusedInput && isSameDay(day, hoverDate); | |||
There was a problem hiding this comment.
I think with the new perf rearchitecture in v11.0.0, we will also have to wrap https://github.com/chris-verclytte/react-dates/blob/c5e7fae7986518dec6cb4e2438d5f0a402d15605/src/components/DayPickerRangeController.jsx#L400-L425 in a if (focusedInput) conditional in this PR.
…nt hovering unnecessarily
majapw
approved these changes
May 10, 2017
|
Thanks for this one, I did not found the time to do it this week ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #479.
Usefull for DatePicker "resetting" focusedInput when clicking outside of the component.
It avoids DatePicker from showing hover style on day when hovered if the DayPicker does not have
focus.