Tap performance followup, fixes and specs #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 30, 2017 18:00
This reverts commit d2e2320.
moonboots
commented
Mar 31, 2017
| @@ -2,8 +2,5 @@ import moment from 'moment'; | |||
|
|
|||
| export default function isSameDay(a, b) { | |||
| if (!moment.isMoment(a) || !moment.isMoment(b)) return false; | |||
| // Speeding up by comparing most likely to differ unit first | |||
| return a.day() === b.day() && | |||
There was a problem hiding this comment.
Moment's day of month function is .date() 😓
There was a problem hiding this comment.
wait why are we changing this back completely
majapw
approved these changes
Mar 31, 2017
|
Thanks, will do |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @majapw @lencioni
Bug in my previous
isSameDaychange. Moment's.day()unfortunately returns day of week, not day of month like I thought. I didn't realize the PR was going to be merged (was adding specs for the modifiers changes, starting to add specs forisSameDaywhen I realized the error).