Moves phrases out into one shared defaultPhrases file #351
Conversation
majapw
added
the
semver-patch: fixes/refactors/etc
| @@ -7,6 +7,7 @@ instrumentation: | |||
| "public/**", | |||
| "test/**", | |||
| "coverage/**", | |||
| "src/defaultPhrases.js" | |||
There was a problem hiding this comment.
also why does this need to be ignored, if it's exercised on every import?
There was a problem hiding this comment.
Fair. I was thinking that we would ignore because writing tests for the file itself seems v. silly
There was a problem hiding this comment.
It's useful to ensure that it can be imported without an error :-)
| @@ -145,13 +144,16 @@ export default class DateRangePickerInput extends React.Component { | |||
| })} | |||
| > | |||
| {(showDefaultInputIcon || customInputIcon !== null) && | |||
| <span | |||
| <button | |||
There was a problem hiding this comment.
was this change meant to be included in this PR?
There was a problem hiding this comment.
Yes. I figured we'd do some of the small aria-labeling/add those phrases unrelated to keyboard nav here.
| @@ -80,6 +91,7 @@ export default function DayPickerNavigation(props) { | |||
| } | |||
|
|
|||
| <span | |||
| aria-label={phrases.jumpToNextMonth} | |||
There was a problem hiding this comment.
Yes. I figured we'd do some of the small aria-labeling/add those phrases unrelated to keyboard nav here.
| @@ -72,6 +82,7 @@ export default function DayPickerNavigation(props) { | |||
| <div className={navClassNames}> | |||
| {!isVerticalScrollable && | |||
| <span | |||
| aria-label={phrases.jumpToPrevMonth} | |||
There was a problem hiding this comment.
Yes. I figured we'd do some of the small aria-labeling/add those phrases unrelated to keyboard nav here.
| @@ -122,13 +121,11 @@ export default class SingleDatePickerInput extends React.Component { | |||
| 'SingleDatePickerInput__clear-date--hide': !displayValue, | |||
| 'SingleDatePickerInput__clear-date--hover': isClearDateHovered, | |||
| })} | |||
| aria-label={phrases.clearDate} | |||
There was a problem hiding this comment.
Yes. I figured we'd do some of the small aria-labeling/add those phrases unrelated to keyboard nav here.
to: @ljharb @airbnb/webinfra
This is to split up some of the code in #301, which I admit, got away from me somewhat.