copy-pasta caused the outsideclickhandler to always be undefined in attached SDPs #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
added
the
semver-patch: fixes/refactors/etc
lencioni
approved these changes
Feb 2, 2017
|
It would be nice to have a test or eslint rule to prevent this kind of thing from happening again |
|
the problem is that sometimes we do want it to be undefined, so I'm unsure
what we would test against.
…On Thu, Feb 2, 2017, 3:03 PM Joe Lencioni ***@***.***> wrote:
It would be nice to have a test or eslint rule to prevent this kind of
thing from happening again
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#288 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABUdtb-Gt85KgdODjY1g2G9iLdHOUg35ks5rYmC0gaJpZM4L1v67>
.
|
majapw
deleted the
maja-where-the-heck-did-the-sdp-outsideclickhandler-go
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOOPS.
@airbnb/webinfra @ljharb halp me pls.