Fix duplicate months #279
Merged
Fix duplicate months #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonboots
force-pushed
the
fix-month-conflict
branch
from
75f5812
to
18598a4
Compare
ljharb
requested changes
Feb 1, 2017
| const collisions = months | ||
| .map(m => m.format('YYYY-MM')) | ||
| .reduce((acc, m) => Object.assign( | ||
| {}, acc, { [m]: true } |
There was a problem hiding this comment.
if the invocation parens and every argument can't fit on one line, then each argument must be on a line by itself.
ljharb
added
the
semver-patch: fixes/refactors/etc
majapw
reviewed
Feb 1, 2017
| } else { | ||
| newMonths = months.slice(0, numberOfMonths + 3); | ||
| } | ||
| newMonths = getMonths(initialMonth, numberOfMonths); |
There was a problem hiding this comment.
Technically, I think the reason for this was to not create hella new moment objects when you changed the number of months which I think getMonths does, but I suppose that's a fairly rare edgecase.
majapw
approved these changes
Feb 1, 2017
moonboots
force-pushed
the
fix-month-conflict
branch
from
18598a4
to
7a04a73
Compare
moonboots
force-pushed
the
fix-month-conflict
branch
from
7a04a73
to
f792540
Compare
|
Thanks, fixed the lint and spec issues, ptal |
ljharb
approved these changes
Feb 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @majapw @ljharb
This PR fixes two issues related to duplicate months in
CalendarMonthGrid:numberOfMonths, the last month was duplicated in the first iteration of this loop. I simplified to reuse thegetMonthslogic instead of updating piecemeal. This should only be called whennumberOfMonthschanges, and it shouldn't affect the original perf improvements.CalendarMonthkey to allow more than 12 months. Otherwise, React will only render the first occurrence and printWarning: flattenChildren(...): Encountered two children with the same key.