Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It doesn't work with Internet Explorer 11? #233

Closed
igorescobar opened this issue Dec 27, 2016 · 25 comments
Closed

It doesn't work with Internet Explorer 11? #233

igorescobar opened this issue Dec 27, 2016 · 25 comments
Labels
bug Oh no, something's broken :-(

Comments

@igorescobar
Copy link

It seems that this plugin doesn't work with Internet Explorer 11. Edge works fine.

Any idea on how to fix it?

@ljharb
Copy link
Member

ljharb commented Dec 27, 2016

Can you elaborate on "doesn't work"? It should work down to IE 9, at least.

@igorescobar
Copy link
Author

igorescobar commented Dec 27, 2016

@ljharb It doesn't work at all. The component to select the date don't even appear. Do you want to know something specific? (I also couldn't see any console errors too)

@ljharb
Copy link
Member

ljharb commented Dec 27, 2016

On your site, or on the storybook?

@igorescobar
Copy link
Author

@ljharb After your comment I decided to check it out. it isn't working on our website but I think that I followed everything mentioned in the README. Do I need to do something more to make it work?

@igorescobar
Copy link
Author

igorescobar commented Dec 27, 2016

@igorescobar
Copy link
Author

Well... I guess no help will come from this.

@ljharb
Copy link
Member

ljharb commented Jan 4, 2017

@igorescobar please have patience, this (and the last two weeks) is holiday time in the US.

@ljharb ljharb reopened this Jan 4, 2017
@Valentin1918
Copy link

In IE 11 I have the error which is linked with: "Array.from" -- is indicated, that property "from" is not supported. It seems need to use polyfill: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/from

@ljharb
Copy link
Member

ljharb commented Jan 5, 2017

@Valentin1918 could you perhaps point me to a line number? That's something that'd be relatively trivial to fix.

@Valentin1918
Copy link

It is in lib/components/DayPicker.js line 116

@ljharb ljharb closed this as completed in 0d09626 Jan 6, 2017
@ljharb ljharb added the bug Oh no, something's broken :-( label Jan 6, 2017
@ljharb
Copy link
Member

ljharb commented Jan 6, 2017

Thanks, all fixed for the next release.

@igorescobar
Copy link
Author

@ljharb any idea when it will be released?

@ljharb
Copy link
Member

ljharb commented Jan 6, 2017

I can try for today or tomorrow.

@ljharb
Copy link
Member

ljharb commented Jan 7, 2017

v4.3.1 published.

@Valentin1918
Copy link

Thanks. Also in src/components/DayPicker.jsx (line 241) need to be called calculateDimension but not this.calculateDimension

@ljharb
Copy link
Member

ljharb commented Jan 7, 2017

Thanks, I unpublished 4.3.1 - 4.3.2 will be out tomorrow with that fix.

ljharb added a commit that referenced this issue Jan 8, 2017
@ljharb
Copy link
Member

ljharb commented Jan 9, 2017

v4.3.2 has been published.

@warn4n
Copy link

warn4n commented May 12, 2017

Has there been an IE11 regression since then? I'm getting multiple errors including Array.from etc on version 11.0.1.

@ljharb
Copy link
Member

ljharb commented May 12, 2017

@warn4n Part of v11's breaking changes was that it required Set and Array.from - you now need to use https://npmjs.com/airbnb-js-shims or the equivalent (you should be doing this regardless in older browsers like IE 11)

@warn4n
Copy link

warn4n commented May 12, 2017

@ljharb Great, I'll try that out! Thanks so much for your very quick response!!

@SrTristao
Copy link

Hello, I import react-dates DateRangePicker in my project and testing in IE9 return error "SCRIPT5007: Unable to get value of the property 'isDayBlocked': object is null or undefined", and file initialize.js has const and IE9 not understand const, I changed const to var.

Any idea on how to fix it?

@ljharb
Copy link
Member

ljharb commented Nov 1, 2017

@corohsnk https://github.com/airbnb/react-dates/blob/master/initialize.js doesn't have const, and neither does https://unpkg.com/[email protected]/lib/initialize.js - how are you importing it into your project?

@SrTristao
Copy link

@ljharb I checked in my project, it was with version 13, I updated to the current version (15.0.0) but it still gives error of isDayBlocked: object is null or undefined in IE9

@ljharb
Copy link
Member

ljharb commented Nov 1, 2017

@corohsnk can you file a new issue, and include the stack trace as well as how you're using react-dates? Also, please confirm (in the issue) that you're using airbnb-browser-shims or the equivalent?

@khsily
Copy link

khsily commented Jan 11, 2018

@corohsnk That is because of "this.props.isDayBlocked" in constructor.
I don't know why but lower versions of ie do not support using this.props in constructor so simply changing "this.props.isDayBlocked" to "props.isDayBlocked" will fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Oh no, something's broken :-(
Projects
None yet
Development

No branches or pull requests

6 participants