-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It doesn't work with Internet Explorer 11? #233
Comments
Can you elaborate on "doesn't work"? It should work down to IE 9, at least. |
@ljharb It doesn't work at all. The component to select the date don't even appear. Do you want to know something specific? (I also couldn't see any console errors too) |
On your site, or on the storybook? |
@ljharb After your comment I decided to check it out. it isn't working on our website but I think that I followed everything mentioned in the README. Do I need to do something more to make it work? |
@ljharb you can check it out here: https://www.hole19golf.com/portugal/club-de-golfe-quinta-do-peru |
Well... I guess no help will come from this. |
@igorescobar please have patience, this (and the last two weeks) is holiday time in the US. |
In IE 11 I have the error which is linked with: "Array.from" -- is indicated, that property "from" is not supported. It seems need to use polyfill: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/from |
@Valentin1918 could you perhaps point me to a line number? That's something that'd be relatively trivial to fix. |
It is in lib/components/DayPicker.js line 116 |
Thanks, all fixed for the next release. |
@ljharb any idea when it will be released? |
I can try for today or tomorrow. |
v4.3.1 published. |
Thanks. Also in src/components/DayPicker.jsx (line 241) need to be called calculateDimension but not this.calculateDimension |
Thanks, I unpublished 4.3.1 - 4.3.2 will be out tomorrow with that fix. |
v4.3.2 has been published. |
Has there been an IE11 regression since then? I'm getting multiple errors including Array.from etc on version 11.0.1. |
@warn4n Part of v11's breaking changes was that it required |
@ljharb Great, I'll try that out! Thanks so much for your very quick response!! |
Hello, I import react-dates DateRangePicker in my project and testing in IE9 return error "SCRIPT5007: Unable to get value of the property 'isDayBlocked': object is null or undefined", and file initialize.js has const and IE9 not understand const, I changed const to var. Any idea on how to fix it? |
@corohsnk https://github.com/airbnb/react-dates/blob/master/initialize.js doesn't have |
@ljharb I checked in my project, it was with version 13, I updated to the current version (15.0.0) but it still gives error of isDayBlocked: object is null or undefined in IE9 |
@corohsnk can you file a new issue, and include the stack trace as well as how you're using react-dates? Also, please confirm (in the issue) that you're using airbnb-browser-shims or the equivalent? |
@corohsnk That is because of "this.props.isDayBlocked" in constructor. |
It seems that this plugin doesn't work with Internet Explorer 11. Edge works fine.
Any idea on how to fix it?
The text was updated successfully, but these errors were encountered: