-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue where a system without autoprefixing will not allow for month transitions in safari #220
Conversation
…onth transitions in safari
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we should apply the autoprefixer in this repo if we can, even if it replaces the scss inline for the build
Yeah. I figure we can push this out as a quick fix and then I can put together another PR to add autoprefixing directly in the repo. :)
|
-webkit-transition: -webkit-transform 0.2s ease-in-out; |
i mean, it will be fixed by autoprefixer of course, but in this quick fix u need to use prefixed transform |
Jokes @lpk3nny is right. The transition is not the problem so much as the transform. I will update that. Will make that change. |
Did it in 92c2cfd. Going to do a new release now. |
Fixes #195
So I believe that adding this prefixes on the transition css prop should fix the issue @awhenderson was having where their implementation would not transition properly in Safari. I think that we have an autoprefixer at airbnb that automagically does this for us, but given that not everyone has this set-up, this should patch the problem for now.
@awhenderson let me know if this fixes your issue!
to: @airbnb/webinfra