Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds back DayPickerWidth initialization on componentDidMount #215

Merged
merged 1 commit into from
Dec 16, 2016

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented Dec 16, 2016

I realize while that only doing this in componentWillReceiveProps while it works for a component that shows/hides the DayPicker, it does not get triggered before the DayPicker is visible if you are using that component directly. D: So uh, let's fix that.

Fixes #214

to: @airbnb/webinfra @yangaobo

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 86.384% when pulling 09d7b75 on maja-fix-daypicker-width-issue into 0b872b0 on master.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. worth a test?

@majapw
Copy link
Collaborator Author

majapw commented Dec 16, 2016

We don't have DOM/mount tests yet on this repo. :/ Maybe we can set that up?

@majapw majapw merged commit 3df89db into master Dec 16, 2016
@majapw majapw deleted the maja-fix-daypicker-width-issue branch December 16, 2016 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PrevMonth & NextMonth don't work correctly after upgrade to 4.1.1
3 participants