Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

fix README #193

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

fix README #193

wants to merge 9 commits into from

Conversation

duoertai
Copy link
Contributor

No description provided.

@ljharb
Copy link
Collaborator

ljharb commented May 14, 2022

I’m not sure how this is a fix - is this perhaps correct for a different version of ruby/rails?

@duoertai
Copy link
Contributor Author

I’m not sure how this is a fix - is this perhaps correct for a different version of ruby/rails?

resubmitting https://github.com/airbnb/hypernova/pull/169/files

@duoertai
Copy link
Contributor Author

@ljharb should we just remove v4 and v5 tests? seems it doesn't support destructuring and introduce 'unexpected token ...' error

@ljharb
Copy link
Collaborator

ljharb commented May 14, 2022

No, first we should fix them. We should be able to use any syntax if we have Babel set up right.

@ljharb
Copy link
Collaborator

ljharb commented May 14, 2022

Please don’t “resubmit” PRs; old ones can and should be reused. Every PR is a permanent ref on the repo, and creating duplicates just pollutes things.

@duoertai duoertai closed this May 14, 2022
@duoertai duoertai reopened this May 14, 2022
@ljharb
Copy link
Collaborator

ljharb commented May 14, 2022

I think maybe updating the Airbnb preset is probably a better bet

@duoertai
Copy link
Contributor Author

I think maybe updating the Airbnb preset is probably a better bet

OK. But after adding the plugin, it's working on my local with node v5, not sure why the test is still failing in github

@duoertai duoertai marked this pull request as draft May 14, 2022 23:05
@duoertai
Copy link
Contributor Author

@ljharb is the babel version setup in uses: ljharb/actions/.github/workflows/node.yml@main ? not sure how to proceed

@duoertai duoertai closed this Feb 15, 2023
@ljharb ljharb reopened this Feb 15, 2023
@duoertai duoertai closed this Feb 16, 2023
@ljharb
Copy link
Collaborator

ljharb commented Feb 16, 2023

if this is left open, then someone else can pick it up.

@ljharb ljharb reopened this Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants