-
Notifications
You must be signed in to change notification settings - Fork 86
[ODM] support aggregation for label join #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2796bc9
[ODM] support aggregation for label join
3549a59
support event label aggregations
afd876b
add test for final view
b3d881c
cleanup
5853507
api update
25a5b0d
data gen test
1d973b8
add more validations
73d61bf
rebase & remove labelHash
c17ba31
comments
a2b80f5
update offset
0cc9f07
doc update
0149559
lint
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
api/py/test/sample/joins/sample_team/sample_label_join_with_agg.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| """ | ||
| Sample Label Join | ||
| """ | ||
| from sources import test_sources | ||
| from group_bys.sample_team import ( | ||
| event_sample_group_by, | ||
| entity_sample_group_by_from_module, | ||
| group_by_with_kwargs, | ||
| ) | ||
|
|
||
| from ai.chronon.join import Join, JoinPart, LabelPart | ||
| from ai.chronon.group_by import ( | ||
| GroupBy, | ||
| Aggregation, | ||
| Operation, | ||
| Window, | ||
| TimeUnit, | ||
| ) | ||
|
|
||
| label_part_group_by = GroupBy( | ||
| name="sample_label_group_by", | ||
| sources=test_sources.entity_source, | ||
| keys=["group_by_subject"], | ||
| aggregations=[ | ||
| Aggregation(input_column="group_by_subject", operation=Operation.SUM, windows=[Window(7, TimeUnit.DAYS)]), | ||
| ], | ||
| online=False, | ||
| ) | ||
|
|
||
| v1 = Join( | ||
| left=test_sources.event_source, | ||
| output_namespace="sample_namespace", | ||
| right_parts=[ | ||
| JoinPart( | ||
| group_by=event_sample_group_by.v1, | ||
| key_mapping={'subject': 'group_by_subject'}, | ||
| ), | ||
| JoinPart( | ||
| group_by=group_by_with_kwargs.v1, | ||
| key_mapping={'subject': 'group_by_subject'}, | ||
| ), | ||
| ], | ||
| label_part=LabelPart([ | ||
| JoinPart( | ||
| group_by=label_part_group_by | ||
| ), | ||
| ], | ||
| left_start_offset=7, | ||
| left_end_offset=7, | ||
| label_offline_schedule="@weekly" | ||
| ), | ||
| additional_args={ | ||
| 'custom_arg': 'custom_value' | ||
| }, | ||
| additional_env={ | ||
| 'custom_env': 'custom_env_value' | ||
| }, | ||
| online=False | ||
| ) |
249 changes: 249 additions & 0 deletions
249
api/py/test/sample/production/joins/sample_team/sample_label_join_with_agg.v1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,249 @@ | ||
| { | ||
| "metaData": { | ||
| "name": "sample_team.sample_label_join_with_agg.v1", | ||
| "online": 0, | ||
| "production": 0, | ||
| "customJson": "{\"check_consistency\": false, \"lag\": 0, \"additional_args\": {\"custom_arg\": \"custom_value\"}, \"additional_env\": {\"custom_env\": \"custom_env_value\"}, \"join_tags\": null, \"join_part_tags\": {}}", | ||
| "dependencies": [ | ||
| "{\"name\": \"wait_for_sample_namespace.sample_table_group_by_ds\", \"spec\": \"sample_namespace.sample_table_group_by/ds={{ ds }}\", \"start\": \"2021-04-09\", \"end\": null}", | ||
| "{\"name\": \"wait_for_sample_namespace.sample_table_group_by_ds\", \"spec\": \"sample_namespace.sample_table_group_by/ds={{ ds }}\", \"start\": \"2021-03-01\", \"end\": \"2021-04-09\"}", | ||
| "{\"name\": \"wait_for_sample_namespace.another_sample_table_group_by_ds\", \"spec\": \"sample_namespace.another_sample_table_group_by/ds={{ ds }}\", \"start\": \"2021-03-01\", \"end\": null}" | ||
| ], | ||
| "tableProperties": { | ||
| "source": "chronon" | ||
| }, | ||
| "outputNamespace": "sample_namespace", | ||
| "team": "sample_team", | ||
| "samplePercent": 100.0, | ||
| "offlineSchedule": "@daily" | ||
| }, | ||
| "left": { | ||
| "events": { | ||
| "table": "sample_namespace.sample_table_group_by", | ||
| "query": { | ||
| "selects": { | ||
| "event": "event_expr", | ||
| "group_by_subject": "group_by_expr", | ||
| "ts": "ts" | ||
| }, | ||
| "startPartition": "2021-04-09", | ||
| "timeColumn": "ts", | ||
| "setups": [] | ||
| } | ||
| } | ||
| }, | ||
| "joinParts": [ | ||
| { | ||
| "groupBy": { | ||
| "metaData": { | ||
| "name": "sample_team.event_sample_group_by.v1", | ||
| "online": 1, | ||
| "customJson": "{\"lag\": 0, \"groupby_tags\": {\"TO_DEPRECATE\": true}, \"column_tags\": {\"event_sum_7d\": {\"DETAILED_TYPE\": \"CONTINUOUS\"}}}", | ||
| "dependencies": [ | ||
| "{\"name\": \"wait_for_sample_namespace.sample_table_group_by_ds\", \"spec\": \"sample_namespace.sample_table_group_by/ds={{ ds }}\", \"start\": \"2021-04-09\", \"end\": null}" | ||
| ], | ||
| "tableProperties": { | ||
| "source": "chronon" | ||
| }, | ||
| "outputNamespace": "sample_namespace", | ||
| "team": "sample_team", | ||
| "offlineSchedule": "@daily" | ||
| }, | ||
| "sources": [ | ||
| { | ||
| "events": { | ||
| "table": "sample_namespace.sample_table_group_by", | ||
| "query": { | ||
| "selects": { | ||
| "event": "event_expr", | ||
| "group_by_subject": "group_by_expr" | ||
| }, | ||
| "startPartition": "2021-04-09", | ||
| "timeColumn": "ts", | ||
| "setups": [] | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "keyColumns": [ | ||
| "group_by_subject" | ||
| ], | ||
| "aggregations": [ | ||
| { | ||
| "inputColumn": "event", | ||
| "operation": 7, | ||
| "argMap": {}, | ||
| "windows": [ | ||
| { | ||
| "length": 7, | ||
| "timeUnit": 1 | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "inputColumn": "event", | ||
| "operation": 7, | ||
| "argMap": {} | ||
| }, | ||
| { | ||
| "inputColumn": "event", | ||
| "operation": 12, | ||
| "argMap": { | ||
| "k": "200", | ||
| "percentiles": "[0.99, 0.95, 0.5]" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "keyMapping": { | ||
| "subject": "group_by_subject" | ||
| } | ||
| }, | ||
| { | ||
| "groupBy": { | ||
| "metaData": { | ||
| "name": "sample_team.group_by_with_kwargs.v1", | ||
| "online": 1, | ||
| "customJson": "{\"additional_argument\": \"To be placed in customJson\", \"lag\": 0, \"groupby_tags\": null, \"column_tags\": {}}", | ||
| "dependencies": [ | ||
| "{\"name\": \"wait_for_sample_namespace.sample_table_group_by_ds\", \"spec\": \"sample_namespace.sample_table_group_by/ds={{ ds }}\", \"start\": \"2021-03-01\", \"end\": \"2021-04-09\"}", | ||
| "{\"name\": \"wait_for_sample_namespace.another_sample_table_group_by_ds\", \"spec\": \"sample_namespace.another_sample_table_group_by/ds={{ ds }}\", \"start\": \"2021-03-01\", \"end\": null}" | ||
| ], | ||
| "tableProperties": { | ||
| "source": "chronon" | ||
| }, | ||
| "outputNamespace": "chronon_db", | ||
| "team": "sample_team", | ||
| "offlineSchedule": "@daily" | ||
| }, | ||
| "sources": [ | ||
| { | ||
| "events": { | ||
| "table": "sample_namespace.sample_table_group_by", | ||
| "query": { | ||
| "selects": { | ||
| "group_by_subject": "group_by_subject_expr_old_version", | ||
| "event": "event_expr_old_version" | ||
| }, | ||
| "startPartition": "2021-03-01", | ||
| "endPartition": "2021-04-09", | ||
| "timeColumn": "UNIX_TIMESTAMP(ts) * 1000", | ||
| "setups": [] | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "events": { | ||
| "table": "sample_namespace.another_sample_table_group_by", | ||
| "query": { | ||
| "selects": { | ||
| "group_by_subject": "possibly_different_group_by_subject_expr", | ||
| "event": "possibly_different_event_expr" | ||
| }, | ||
| "startPartition": "2021-03-01", | ||
| "timeColumn": "__timestamp", | ||
| "setups": [] | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "keyColumns": [ | ||
| "group_by_subject" | ||
| ], | ||
| "aggregations": [ | ||
| { | ||
| "inputColumn": "event", | ||
| "operation": 7, | ||
| "argMap": {} | ||
| }, | ||
| { | ||
| "inputColumn": "event", | ||
| "operation": 12, | ||
| "argMap": { | ||
| "k": "128", | ||
| "percentiles": "[0.5]" | ||
| } | ||
| }, | ||
| { | ||
| "inputColumn": "event", | ||
| "operation": 7, | ||
| "argMap": {}, | ||
| "windows": [ | ||
| { | ||
| "length": 7, | ||
| "timeUnit": 1 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| "keyMapping": { | ||
| "subject": "group_by_subject" | ||
| } | ||
| } | ||
| ], | ||
| "labelPart": { | ||
| "labels": [ | ||
| { | ||
| "groupBy": { | ||
| "metaData": { | ||
| "name": "sample_label_group_by", | ||
| "online": 0, | ||
| "customJson": "{\"lag\": 0, \"groupby_tags\": null, \"column_tags\": {}}", | ||
| "dependencies": [ | ||
| "{\"name\": \"wait_for_sample_table.sample_entity_snapshot_ds\", \"spec\": \"sample_table.sample_entity_snapshot/ds={{ ds }}\", \"start\": \"2021-03-01\", \"end\": null}", | ||
| "{\"name\": \"wait_for_sample_table.sample_entity_mutations_ds\", \"spec\": \"sample_table.sample_entity_mutations/ds={{ ds }}/hr=00:00\", \"start\": \"2021-03-01\", \"end\": null}" | ||
| ], | ||
| "team": "sample_team", | ||
| "offlineSchedule": "@daily" | ||
| }, | ||
| "sources": [ | ||
| { | ||
| "entities": { | ||
| "snapshotTable": "sample_table.sample_entity_snapshot", | ||
| "mutationTable": "sample_table.sample_entity_mutations/hr=00:00", | ||
| "mutationTopic": "sample_topic", | ||
| "query": { | ||
| "selects": { | ||
| "group_by_subject": "group_by_subject_expr", | ||
| "entity": "entity_expr" | ||
| }, | ||
| "startPartition": "2021-03-01", | ||
| "timeColumn": "ts", | ||
| "setups": [] | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "keyColumns": [ | ||
| "group_by_subject" | ||
| ], | ||
| "aggregations": [ | ||
| { | ||
| "inputColumn": "group_by_subject", | ||
| "operation": 7, | ||
| "argMap": {}, | ||
| "windows": [ | ||
| { | ||
| "length": 7, | ||
| "timeUnit": 1 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ], | ||
| "leftStartOffset": 7, | ||
| "leftEndOffset": 7, | ||
| "metaData": { | ||
| "dependencies": [ | ||
| "{\"name\": \"wait_for_sample_namespace.sample_table_group_by_ds\", \"spec\": \"sample_namespace.sample_table_group_by/ds={{ ds }}\", \"start\": \"2021-04-09\", \"end\": null}", | ||
| "{\"name\": \"wait_for_sample_table.sample_entity_snapshot_ds\", \"spec\": \"sample_table.sample_entity_snapshot/ds={{ ds }}\", \"start\": \"2021-03-01\", \"end\": null}", | ||
| "{\"name\": \"wait_for_sample_table.sample_entity_mutations_ds\", \"spec\": \"sample_table.sample_entity_mutations/ds={{ ds }}/hr=00:00\", \"start\": \"2021-03-01\", \"end\": null}", | ||
| "{\"name\": \"wait_for_sample_namespace.sample_team_sample_label_join_with_agg_v1\", \"spec\": \"sample_namespace.sample_team_sample_label_join_with_agg_v1/ds={{ ds }}\"}" | ||
| ], | ||
| "offlineSchedule": "@weekly" | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file doesn't have label_ds defined. The label join is complicated, maybe add an example in your doc to explain these ds, offset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point will do