Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tzinfo config, useful when start druid without utc timezone #20

Merged
merged 1 commit into from
Sep 9, 2015

Conversation

wbchn
Copy link
Contributor

@wbchn wbchn commented Sep 6, 2015

I startup druid cluster with America/Los_Angeles timezone(both cluster instances and druid commands).

Then I found the query of table view(Now: 02:05:56 PDT / 10:05:56 UTC), the intervals of query using none timezone information:

// Two phase query
// Phase 1
{
  "dimensions": [], 
  "aggregations": [
    {
      "type": "count", 
      "name": "count"
    }
  ], 
  "intervals": "2015-09-05T02:05:56/2015-09-06T02:05:56", 
  "dataSource": "..."
...

It queried data before 2015-09-06T02:05:56 UTC, but can not query data between 2015-09-06T02:05:57 UTC ~ 2015-09-06T10:05:56 UTC. May be it would be "intervals": "2015-09-05T02:05:56-07:00/2015-09-06T02:05:56-07:00".

so I add this tzinfo configure, setting DRUID_TZ = tz.tzlocal() when start druid without UTC timezone(of course, it also work fine if both cluster instances and druid using UTC timezone).

@mistercrunch
Copy link
Member

Awesome thanks!

mistercrunch added a commit that referenced this pull request Sep 9, 2015
add tzinfo config, useful when start druid without utc timezone
@mistercrunch mistercrunch merged commit 7f9d96b into apache:master Sep 9, 2015
@wbchn
Copy link
Contributor Author

wbchn commented Sep 10, 2015

Sorry, I've forgotten to add timezone to granularity of json, and I will test and pull again.

Thanks for your open project.

michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request Mar 12, 2018
…RLParams

Cherry Pick: [Explore] Save custom url parameters when user save slices (apache#4578)
hughhhh referenced this pull request in lyft/incubator-superset Apr 1, 2018
Merging halloween dev branch to master since code freeze is over

@lyft/command-center @amalakar @amalakar
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
* add initial files

* update references

* fix lint issues

* Define top-level exports

* disable linting for color schemes

* update test

* update travis

* update travis

* revert travis

* install once

* update clear()

* update core index test

* update color index test

* update travis

* try build before test

* update unit tes

* override beemo config

* remove test command

* update ignore path

* use new build config
zhaoyongjie pushed a commit that referenced this pull request Nov 24, 2021
* add initial files

* update references

* fix lint issues

* Define top-level exports

* disable linting for color schemes

* update test

* update travis

* update travis

* revert travis

* install once

* update clear()

* update core index test

* update color index test

* update travis

* try build before test

* update unit tes

* override beemo config

* remove test command

* update ignore path

* use new build config
zhaoyongjie pushed a commit that referenced this pull request Nov 25, 2021
* add initial files

* update references

* fix lint issues

* Define top-level exports

* disable linting for color schemes

* update test

* update travis

* update travis

* revert travis

* install once

* update clear()

* update core index test

* update color index test

* update travis

* try build before test

* update unit tes

* override beemo config

* remove test command

* update ignore path

* use new build config
zhaoyongjie pushed a commit that referenced this pull request Nov 26, 2021
* add initial files

* update references

* fix lint issues

* Define top-level exports

* disable linting for color schemes

* update test

* update travis

* update travis

* revert travis

* install once

* update clear()

* update core index test

* update color index test

* update travis

* try build before test

* update unit tes

* override beemo config

* remove test command

* update ignore path

* use new build config
@eschutho eschutho mentioned this pull request Jan 10, 2023
9 tasks
rguerraZero added a commit to rguerraZero/superset that referenced this pull request Feb 9, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.4.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants