Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing window resize for explore and standalone #165

Merged
merged 2 commits into from
Mar 4, 2016
Merged

Conversation

mistercrunch
Copy link
Member

@williaster @askeys, this seems to do it

@@ -217,6 +217,15 @@ var px = (function () {
others += widget.find('.slice_header').height();
return widget.height() - others;
},
setResizeOnWindowResize: function () {
var resizeTimer;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is basically to make sure that the function is called when the resizing is done, as opposed to calling the function a thousand times during the drag event

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, then your browser won't crash :) nit I think bindResizeToWindowResize is a better name but LGTM 👍

@askeys
Copy link

askeys commented Mar 4, 2016

👍

mistercrunch added a commit that referenced this pull request Mar 4, 2016
Fixing window resize for explore and standalone
@mistercrunch mistercrunch merged commit e39f7db into master Mar 4, 2016
@mistercrunch mistercrunch deleted the window_resize branch March 4, 2016 23:57
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
…apache#165)

* feat: add basic functionality for icicle chart to display static data

adds functionality for the icicle chart to have data passed in and display (static, no interactions
yet)

* feat: increase code coverage to pass check

* feat: clarify contentRenderer argument types
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
…apache#165)

* feat: add basic functionality for icicle chart to display static data

adds functionality for the icicle chart to have data passed in and display (static, no interactions
yet)

* feat: increase code coverage to pass check

* feat: clarify contentRenderer argument types
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
…apache#165)

* feat: add basic functionality for icicle chart to display static data

adds functionality for the icicle chart to have data passed in and display (static, no interactions
yet)

* feat: increase code coverage to pass check

* feat: clarify contentRenderer argument types
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
…apache#165)

* feat: add basic functionality for icicle chart to display static data

adds functionality for the icicle chart to have data passed in and display (static, no interactions
yet)

* feat: increase code coverage to pass check

* feat: clarify contentRenderer argument types
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants