simplifying tooltip code #104
Merged
+3
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is that right? I thought you wanted the changes in |
|
I think it is right. Before I was looping through and setting the z-index higher for the more left boxes. But now I don't need that b/c the one that you're hovering over comes all the way to the front. I tested it and no tool tips clip behind anything else anymore. |
|
Perfect. Mergin' |
john-bodley
pushed a commit
to john-bodley/superset
that referenced
this pull request
Sep 6, 2018
Cherry-picks: Updates 8 charts
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 17, 2021
* refactor: use composition package * refactor: remove WithLegend and ChartFrame
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 24, 2021
* refactor: use composition package * refactor: remove WithLegend and ChartFrame
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 25, 2021
* refactor: use composition package * refactor: remove WithLegend and ChartFrame
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 26, 2021
* refactor: use composition package * refactor: remove WithLegend and ChartFrame
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as before but without the merge conflicts.