[bugfix] dashboard list doesn't populate in explore->saveas (#979)

apache · Aug 19, 2016 · a871529 · a871529
1 parent c7467f5
commit a871529
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/caravel/assets/javascripts/welcome.js b/caravel/assets/javascripts/welcome.js
@@ -14,13 +14,14 @@ function modelViewTable(selector, modelView, orderCol, order) {
   url += '?_oc_' + modelView + '=' + orderCol;
   url += '&_od_' + modelView + '=' + order;
   $.getJSON(url, function (data) {
+    const columns = ['dashboard_link', 'creator', 'modified'];
     const tableData = $.map(data.result, function (el) {
-      const row = $.map(data.list_columns, function (col) {
+      const row = $.map(columns, function (col) {
         return el[col];
       });
       return [row];
     });
-    const cols = $.map(data.list_columns, function (col) {
+    const cols = $.map(columns, function (col) {
       return { sTitle: data.label_columns[col] };
     });
     const panel = $(selector).parents('.panel');

diff --git a/caravel/views.py b/caravel/views.py
@@ -728,7 +728,7 @@ def pre_delete(self, obj):
 
 
 class DashboardModelViewAsync(DashboardModelView):  # noqa
-    list_columns = ['dashboard_link', 'creator', 'modified']
+    list_columns = ['dashboard_link', 'creator', 'modified', 'dashboard_title']
     label_columns = {
         'dashboard_link': 'Dashboard',
     }