fix(query): removed from get_chat_history #109
Conversation
There was a problem hiding this comment.
@dyaramatreya The query parameter should to be removed in VectorDBMemory aswell.
tarun-aiplanet
added
the
hacktoberfest-accepted
|
@shreehari-aiplanet please review the changes and suggest any changes if needed |
There was a problem hiding this comment.
Changes look good @dyaramatreya . Can you just paste a screenshot of the successful passing testcase of this PR. Since we dont have tests CI yet this would be useful.
|
@sam-aiplanet Sorry. I'm trying to run them, but since I'm contributing from my enterprise/company's laptop, I'm unable to install some packages due to permissions. |
@dyaramatreya Hi thank you for your contribution, but we will try running them since we are low on team bandwidth we really can't guarantee. Please try any other alternatives if possible . Thank you |
Hi @sam-aiplanet. |
There was a problem hiding this comment.
Hi @dyaramatreya, thank you for your contribution, i ran testcase but it failed, it is because the testcase is not updated. initially it was possible to test few components independently but it was changed in the later releases. currently it requires a stack to be initialized by passing the component instance to it.
you can refer this as example : https://github.com/aiplanethub/genai-stack/blob/main/tests/test_model.py
retriever.get_chat_history()#105