Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop strict mode #123

Closed
asvetlov opened this issue Oct 20, 2017 · 14 comments
Closed

Drop strict mode #123

asvetlov opened this issue Oct 20, 2017 · 14 comments

Comments

@asvetlov
Copy link
Member

We don't respect it by URL cloning anyway.
I don't see a use case where strict mode is useful.

@kxepal
Copy link
Member

kxepal commented Oct 20, 2017

What strict mode does in short?

@asvetlov
Copy link
Member Author

asvetlov commented Oct 20, 2017 via email

@asvetlov
Copy link
Member Author

Fixed by #133

@balloob
Copy link

balloob commented Nov 11, 2017

Can we adopt semver for yarl? Since this was a breaking change I would have expected a major version bump. Now the new version is automatically installed with aiohttp and breaking new installations of Home Assistant 😶

@asvetlov
Copy link
Member Author

It was a smooth update for aiohttp 2.3 but incompatible change for 2.2 (half an year old BTW).

@asvetlov
Copy link
Member Author

But in general you are right -- yarl needs 1.0 major release.

@pascal-de-ladurantaye
Copy link

This broke all our builds overnight. You cannot assume that, because a version is half a year old, it's not used in production by anyone.
I appreciate the work you put in aiohttp and love the library. But versioning exists for a reason.

@asvetlov
Copy link
Member Author

@pascal-de-ladurantaye please pin yarl 0.13 on your build boxes until upgrade aiohttp to 2.3

@balloob
Copy link

balloob commented Nov 13, 2017

Yeah, it's recommended to use Pipenv instead of requirements so that all dependencies are locked to a version and you can do reproducible builds.

@pascal-de-ladurantaye
Copy link

It is also recommended to not introduce breaking changes in a minor version bump.

@fafhrd91
Copy link
Member

@asvetlov i think new aiohttp 2.2 should be released. Aiohttp had specific requirements for yarl, I added it because situation like this already happened

@asvetlov
Copy link
Member Author

@fafhrd91 makes sense.
I pretty sure autodeployment for aiohttp 2.2 is broken, I recall some issues with binary wheels.
Please let me check it and backport related changes first.

@asvetlov
Copy link
Member Author

Fixed by 0.14.1 release

@asvetlov
Copy link
Member Author

Sorry, it was my fault.
I hope the failure didn't break anybody's life.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants