-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop strict mode #123
Comments
What strict mode does in short? |
Raises an exception for not property percent encoded strings like z%A-text.
Relaxed mode just leaves them as is.
|
Fixed by #133 |
Can we adopt semver for yarl? Since this was a breaking change I would have expected a major version bump. Now the new version is automatically installed with aiohttp and breaking new installations of Home Assistant 😶 |
It was a smooth update for aiohttp 2.3 but incompatible change for 2.2 (half an year old BTW). |
But in general you are right -- yarl needs 1.0 major release. |
This broke all our builds overnight. You cannot assume that, because a version is half a year old, it's not used in production by anyone. |
@pascal-de-ladurantaye please pin yarl 0.13 on your build boxes until upgrade aiohttp to 2.3 |
Yeah, it's recommended to use Pipenv instead of requirements so that all dependencies are locked to a version and you can do reproducible builds. |
It is also recommended to not introduce breaking changes in a minor version bump. |
@asvetlov i think new aiohttp 2.2 should be released. Aiohttp had specific requirements for yarl, I added it because situation like this already happened |
@fafhrd91 makes sense. |
Fixed by 0.14.1 release |
Sorry, it was my fault. |
We don't respect it by URL cloning anyway.
I don't see a use case where strict mode is useful.
The text was updated successfully, but these errors were encountered: