Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for aiopg maintainer #384

Open
asvetlov opened this issue Sep 10, 2017 · 15 comments
Open

Call for aiopg maintainer #384

asvetlov opened this issue Sep 10, 2017 · 15 comments

Comments

@asvetlov
Copy link
Member

The project needs more love.
Unfortunately I am and @jettify are overwhelmed by other Open Source projects.
I personally sped most spare time on aiohttp issues.

We need a responsible person for monitoring aiopg issues and reviewing pull requests.

I don't want to give up the project support.

The plan is:

  • a volunteer's duty is answering on issues and taking careful review.
  • all non-trivial changes approved by this guy also require approval from me or @jettify for trial period at least.
  • I'm and @jettify are BDFLs for the project

Anybody want to bear the duty?

@1st1
Copy link

1st1 commented Sep 11, 2017

I'd at least consider deprecating the project in favour of asyncpg.

@DeoLeung
Copy link

asyncpg looks fancy but for OLAP application there seems not a strong benefit to move from aiopg considering the engineering cost.

@jettify
Copy link
Member

jettify commented Sep 13, 2017

I do not think we are going to deprecate this project, asyncpg looks nice and stuff, but

  1. It is different form usual DBAPI spec
  2. there are existing projects that relies on it
  3. psycopg2 is almost standard postgres driver for python

@tvoinarovskyi
Copy link
Member

@jettify What should we do with aiomysq, are you still supporting it? Any alternative out there?
I ask cause those are quite similar projects, at least from the API perspective.

@elprans
Copy link

elprans commented Sep 27, 2017

@jettify FWIW it should be possible to implement a DBAPI-like facade on top of asyncpg that is fully compatible with aiopg API. The main issue here is the duplication of effort in the asyncio-specific parts and things like the connection pool.

@jettify
Copy link
Member

jettify commented Oct 15, 2017

@elprans Agreed it would be nice to have asyncpg as backend.

@vir-mir
Copy link
Member

vir-mir commented Nov 29, 2017

@asvetlov I can try, i also use in work, you can write off in the mail virmir49 gmail

@jettify
Copy link
Member

jettify commented Dec 1, 2017

@asvetlov we need more help here so if you do not mind I will add @vir-mir to the the committers. He knows aiopg internals and contributed large PR #219 it was not merged mostly because lack of time on our part.

@asvetlov
Copy link
Member Author

asvetlov commented Dec 1, 2017

Agree

@vir-mir
Copy link
Member

vir-mir commented Dec 2, 2017

@jettify what further actions? I do not yet have access.

@jettify
Copy link
Member

jettify commented Dec 2, 2017

@vir-mir sent you invitation let me know if you have access (you should be able to merge #219 ).

Please follow this simple rules:

  1. on each change please create pull request
  2. each PR should be reviewed and tested
  3. if PR is not commented for more than 3-5 days by other maintainers, feel free to merge it
  4. be nice and respectful to others :)

https://github.com/aio-libs/aiohttp/blob/master/CONTRIBUTING.rst#how-to-become-an-aiohttp-committer

And wellcome to aio-libs team!

@vir-mir
Copy link
Member

vir-mir commented Dec 2, 2017

@jettify Thank you! access is!

@JohnTitor
Copy link

@asvetlov @jettify I'm not an expert, but interested in aiopg. I'd like to join.

@webknjaz
Copy link
Member

webknjaz commented Jan 7, 2019

@JohnTitor you could try going through issues and see what you can do

@JohnTitor
Copy link

@webknjaz OK, I'll try. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants