Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Mypy 0.910 #5890

Merged
merged 3 commits into from
Jul 18, 2021
Merged

Update to Mypy 0.910 #5890

merged 3 commits into from
Jul 18, 2021

Conversation

Dreamsorcerer
Copy link
Member

No description provided.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jul 17, 2021
@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #5890 (bf13421) into master (e3dcc71) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5890   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files          44       44           
  Lines        9851     9851           
  Branches     1591     1591           
=======================================
  Hits         9531     9531           
  Misses        182      182           
  Partials      138      138           
Flag Coverage Δ
unit 96.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3dcc71...bf13421. Read the comment docs.

@Dreamsorcerer Dreamsorcerer merged commit ae23fd6 into master Jul 18, 2021
@Dreamsorcerer Dreamsorcerer deleted the mypy branch July 18, 2021 11:45
@patchback
Copy link
Contributor

patchback bot commented Jul 18, 2021

Backport to 3.8: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply ae23fd6 on top of patchback/backports/3.8/ae23fd6a1645eacaf63d64c638f19310282d07b9/pr-5890

Backporting merged PR #5890 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.8/ae23fd6a1645eacaf63d64c638f19310282d07b9/pr-5890 upstream/3.8
  4. Now, cherry-pick PR Update to Mypy 0.910 #5890 contents into that branch:
    $ git cherry-pick -x ae23fd6a1645eacaf63d64c638f19310282d07b9
    If it'll yell at you with something like fatal: Commit ae23fd6a1645eacaf63d64c638f19310282d07b9 is a merge but no -m option was given., add -m 1 as follows intead:
    $ git cherry-pick -m1 -x ae23fd6a1645eacaf63d64c638f19310282d07b9
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Update to Mypy 0.910 #5890 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.8/ae23fd6a1645eacaf63d64c638f19310282d07b9/pr-5890
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant