-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type hint istr keys allowed in LooseHeaders #3976
Conversation
So one can use e.g. {hdrs.SOMETHING: ...} as headers.
Codecov Report
@@ Coverage Diff @@
## master #3976 +/- ##
==========================================
- Coverage 97.77% 97.75% -0.03%
==========================================
Files 43 43
Lines 8763 8763
Branches 1375 1375
==========================================
- Hits 8568 8566 -2
- Misses 83 84 +1
- Partials 112 113 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR idea is correct.
To make it merged please:
- Run
make isort
to reorder imports and get Travis CI passed. - Write a record in
CHANGES
folder.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
(cherry picked from commit ec5aee7) Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
What do these changes do?
Allows one to use e.g. {hdrs.SOMETHING: ...} as headers per type checks.
Are there changes in behavior for the user?
No.
Related issue number
I don't think so.
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.