Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features Request: Add HTTPS Support #208

Open
jamesward opened this issue Oct 1, 2018 · 3 comments
Open

Features Request: Add HTTPS Support #208

jamesward opened this issue Oct 1, 2018 · 3 comments

Comments

@jamesward
Copy link

I'm working on an app that must run on https even on localhost (the SSO identity provider requires it). So it'd be great to have HTTPS support.

@pcgeek86
Copy link

pcgeek86 commented Jan 7, 2020

+1 when I run the app over HTTPS, I get a mixed content warning.

Mixed Content: The page at 'https://xxxxxxxxx' was loaded over HTTPS, but requested an insecure script 'http://xxxxxx:8001/livereload.js'. This request has been blocked; the content must be served over HTTPS.

@Dreamsorcerer
Copy link
Member

I doubt I'll look at this, but if someone wants to create a PR to support the feature, then we can add it.

@Dreamsorcerer
Copy link
Member

Just thinking this through, if anyone wants to work on it, we are just calling run_app() at https://github.com/aio-libs/aiohttp-devtools/blob/master/aiohttp_devtools/cli.py#L86

It appears this can be configured with an ssl_context parameter: https://docs.aiohttp.org/en/stable/web_reference.html?highlight=run_app#aiohttp.web.run_app

So, probably an easy task if anyone wants to give it a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants