Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spin-orbit coupling as a main button #981

Closed
edan-bainglass opened this issue Dec 16, 2024 · 7 comments · Fixed by #984
Closed

Add Spin-orbit coupling as a main button #981

edan-bainglass opened this issue Dec 16, 2024 · 7 comments · Fixed by #984
Assignees
Labels
enhancement New feature or request

Comments

@edan-bainglass
Copy link
Member

Make it a main button below the one for magnetism.

  • Name it: "Spin-orbit coupling": "Off" and "On" like magnetism, with Off by default

  • Make sure this also goes into the default label (add "with spin orbit")

@edan-bainglass edan-bainglass added the enhancement New feature or request label Dec 16, 2024
@edan-bainglass edan-bainglass self-assigned this Dec 16, 2024
@edan-bainglass
Copy link
Member Author

@AndresOrtegaGuerrero do you already have a PR for this? I know you've already handled the label in #954. If you're not already handling moving the widget to basic, I got it.

@edan-bainglass
Copy link
Member Author

edan-bainglass commented Dec 17, 2024

image

@cpignedoli @giovannipizzi thoughts? (ignore the capitalization ("Electronic Type") - that will be addressed throughout in a separate PR)

@giovannipizzi
Copy link
Member

lgtm!

@cpignedoli
Copy link
Member

Super @edan-bainglass. We will probably have to add in a different PR some warnings/info on the pseudopotentials to be used and on the fact that one should consider doing geoopt without SOC in "some cases". What do you think?

@AndresOrtegaGuerrero
Copy link
Member

@edan-bainglass, I suggest addressing @cpignedoli's comment in a follow-up PR. Users might perform geometry optimizations with spin-orbit coupling (SOC), which could cause the application to fail repeatedly if resources are not allocated appropriately.

While enabling such calculations is valuable, it might not be ideal for users to proceed without understanding the implications. We should verify whether the example systems have sufficient resources to complete a geometry optimization with SOC (Demo servers resources).

Additionally, it would be helpful to include a caption warning users about the potential need for extra resources when performing SOC calculations compared to calculations without SOC. This would guide users to allocate resources appropriately and avoid unexpected failures.

@edan-bainglass
Copy link
Member Author

@AndresOrtegaGuerrero I agree and counter suggest that you do it 😅 You clearly have a good sense of what should be said there. I'm happy to review the text draft once you have it 😁

@AndresOrtegaGuerrero
Copy link
Member

AndresOrtegaGuerrero commented Dec 22, 2024

I would suggest having a discussion to determine the appropriate text to include and where it should be placed. Based on past experiences with captions, it would be helpful to reach a consensus before proceeding. Once this has been decided, I will be happy to create the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants