Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Should we build qeapp image for arm64? #775

Closed
danielhollas opened this issue Jul 18, 2024 · 5 comments · Fixed by #776
Closed

Discussion: Should we build qeapp image for arm64? #775

danielhollas opened this issue Jul 18, 2024 · 5 comments · Fixed by #776
Labels
enhancement New feature or request

Comments

@danielhollas
Copy link
Contributor

The current docker CI machinery is very complex. If we could ditch the arm64 build, it would become much much simpler and easier to maintain. Given that the arm64 build is likely mainly for developers, I would propose to ditch it and only build for x86. Developers can always use the full-stack image. In fact I think it is beneficial if some devs work from the latest full-stack image so that it receives more dogfooding that way.

NOTE: The arm64 is currently failing, if you want to keep it, we need to switch it to buildjet runners.

WDYT @unkcpz @superstar54

@danielhollas danielhollas added the enhancement New feature or request label Jul 18, 2024
@unkcpz
Copy link
Member

unkcpz commented Jul 18, 2024

In the exist k8s server those are all amd64. Not sure if @mikibonacci and @AndresOrtegaGuerrero who has apple M1/M2 are using qe image or you are running on aiidalab-launch with full-stack and then install QeApp from appstore?

@unkcpz
Copy link
Member

unkcpz commented Jul 18, 2024

I'd vote for removing it. If really needed in the future, it is still easy to bring it back.

@danielhollas
Copy link
Contributor Author

Yes, I think we need to unblock ourselves. I'll remove it for now, and we can revisit in the future. Also I think we should still try to speed up the overall installation process when using the full-stack image. One thing will be swithing to Python 3.11 and pre-installing AWB.

@danielhollas
Copy link
Contributor Author

Here's the biggest argument for removal

image

@unkcpz
Copy link
Member

unkcpz commented Jul 19, 2024

I asked @mikibonacci in person and he is okay with it. He uses full-stack image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants