Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move common code to abstract gia #200

Open
viktorvaladi opened this issue Jan 12, 2025 · 0 comments
Open

move common code to abstract gia #200

viktorvaladi opened this issue Jan 12, 2025 · 0 comments

Comments

@viktorvaladi
Copy link
Collaborator

to move .run_attack(), inverting needs to move to the generator structure (which it should to allow for early stopping in hyperparameter tuning with optuna) the rest should be the same between the two current attacks. The code could for now be in abstract GIA, but if we find that other attacks that does not share this loop we should consider moving it somewhere else.

Same goes for the function "reconstruction_costs", can also be moved to abstract gia for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant