Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like RivescriptJS no longer maintained... #342

Open
I-am-Orion opened this issue May 26, 2020 · 2 comments
Open

Looks like RivescriptJS no longer maintained... #342

I-am-Orion opened this issue May 26, 2020 · 2 comments

Comments

@I-am-Orion
Copy link

I notice, no issue has been solved for the past few months...including my issue...

@I-am-Orion I-am-Orion changed the title Looks like RivescriptJS no longer maintain... Looks like RivescriptJS no longer maintained... May 26, 2020
@dcsan
Copy link
Contributor

dcsan commented May 26, 2020

@kirsle
Copy link
Member

kirsle commented May 27, 2020

If others want to step up and help maintain this repo, get in touch with me and I can see about adding write access for them. I have other priorities nowadays and don't have as much time to be the sole maintainer of this repo. Pull requests are accepted but bug reports that I'm expected to fix myself will be done whenever I have the time and gumption to dive into the codebase once again.

At this stage of the game I consider the RiveScript language spec v2 to be "feature complete" and am only interested in bug fixes and performance optimizations. There's plenty of room for improvement here (for example, ! sub substitutions could be optimized to support massive numbers of substitutions, i.e. to translate all Emoji symbols into text versions, and the current algorithm iterates over them as a list and doesn't scale well for large numbers of substitutions).

So I'd ask prospective maintainers to understand the RiveScript Goals and Scope and to keep feature parity as much as possible between all the implementations of RiveScript: if you wrote a bot using rivescript-js you should be able to take all your .rive files and run them as-is in the Python, Go, Java or Perl versions without needing to modify them: the same feature set should work more or less the same on all these environments (object macro language support excluded). For example, I don't want to see rivescript-js go off on its own tangent and support large extensions to the language unless the maintainer also commits to extending the Go, Python and Java versions (at minimum) to follow these new feature developments. If you'd like to take RiveScript in a new direction, fork the project and name it something else as SuperScript.js did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants