Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken gpu macro #72

Closed
vitskvara opened this issue Dec 18, 2019 · 3 comments
Closed

Broken gpu macro #72

vitskvara opened this issue Dec 18, 2019 · 3 comments

Comments

@vitskvara
Copy link
Collaborator

With the latest changes in ConditionalDists, the gpu macro is broken:

model = VAE(ldim, CMeanVarGaussian{DiagVar}(Dense(3,4)), CMeanVarGaussian{ScalarVar}(Dense(2,4))) |> gpu
ERROR: MethodError: Cannot `convert` an object of type Dense{typeof(identity),CuArray{Float32,2,Nothing},CuArray{Float32,1,Nothing}} to an object of type Dense{typeof(identity),Array{Float32,2},Array{Float32,1}}
Closest candidates are:
  convert(::Type{T}, ::T) where T at essentials.jl:168
  Dense{typeof(identity),Array{Float32,2},Array{Float32,1}}(::Any, ::Any, ::Any) where {F, S, T} at /home/vit/.julia/packages/Flux/oObnA/src/layers/basic.jl:86
Stacktrace:
 [1] CMeanVarGaussian{DiagVar,Dense{typeof(identity),Array{Float32,2},Array{Float32,1}}}(::Dense{typeof(identity),CuArray{Float32,2,Nothing},CuArray{Float32,1,Nothing}}) at /home/vit/.julia/dev/ConditionalDists/src/cmeanvar_gaussian.jl:34
...
@nmheim
Copy link
Member

nmheim commented Dec 18, 2019

Here we go again ^^ I'm travelling for the next 18 hours, so if you want to fix it go ahead :) looks like its trying to construct the cuarray versions with the old type signature for some reason...

@vitskvara
Copy link
Collaborator Author

vitskvara commented Dec 18, 2019

It also seems to have broken training even if the mappings are moved to gpu before construction of the model. Unfortunately I am not sure how to fix this.

@vitskvara
Copy link
Collaborator Author

This is actually an issue with ConditionalDists.jl, so I'll close it here and open it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants