Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test dark visitors update and improve code/test_files/robots.json #52

Open
glyn opened this issue Oct 20, 2024 · 0 comments
Open

Test dark visitors update and improve code/test_files/robots.json #52

glyn opened this issue Oct 20, 2024 · 0 comments

Comments

@glyn
Copy link
Contributor

glyn commented Oct 20, 2024

          I wonder if it's worth reworking this file so that it has less duplication of fields and so that it exercises the consolidation logic thoroughly if testing of dark visitors update is added?

Originally posted by @glyn in #51 (comment)

The tests should be expanded to cover the logic for the dark visitors update, suitably refactored so that the dark visitors input is parameterised. The robots.json test fixture should also be reworked to:

  1. ensure good coverage of the dark visitors logic.
  2. reduce duplication.

(This issue is a follow-on to PR 51, should that be merged.)

@glyn glyn changed the title Test dark visitors update and improve code/test_files/robots.jsonn Test dark visitors update and improve code/test_files/robots.json Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant