Add UCX Plugin Gtests #338
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi glevnv! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
etoledano
reviewed
May 20, 2025
glevnv
force-pushed
the
ucx-gtests
branch
13 times, most recently
from
e905956 to
371562f
Compare
glevnv
force-pushed
the
ucx-gtests
branch
10 times, most recently
from
aa50c48 to
2673c3f
Compare
glevnv
force-pushed
the
ucx-gtests
branch
9 times, most recently
from
c33714a to
248e595
Compare
Add a plugin gtest infrastructure to test baackend plugin local xfer, remote xfer, progress and notification handling. Add ucx plugin gtests on top of the plugin infrastructure.
etoledano
reviewed
May 24, 2025
| } | ||
| }; | ||
|
|
||
| #ifdef HAVE_CUDA |
Contributor
There was a problem hiding this comment.
Please align with @dfarge implementation, allowing to omit these configuration flags from the code
| }; | ||
|
|
||
| template<> struct MemoryHandler<DRAM_SEG> { | ||
| static void * |
Contributor
There was a problem hiding this comment.
Seems that these structs are stateless, maybe a namespace can replace?
|
|
||
| static void | ||
| releasePtr(void *addr) { | ||
| std::cerr << "Unsupported memory type!" << std::endl; |
Contributor
There was a problem hiding this comment.
We have a dedicated logger
| static void | ||
| releasePtr(void *addr) { | ||
| std::cerr << "Unsupported memory type!" << std::endl; | ||
| assert(0); |
Contributor
There was a problem hiding this comment.
Can abseil::CHECK replace? (or one of its flavors)
Comment on lines
+36
to
+38
| static const size_t NUM_BUF_ENTRIES = 64; | ||
| static const size_t BUF_ENTRY_SIZE = 1024 * 1024; | ||
| static const size_t BUF_SIZE = BUF_ENTRY_SIZE * NUM_BUF_ENTRIES; |
Contributor
|
Any update on this @glevnv? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a plugin gtest infrastructure.
Adds ucx plugin gtests on top of the plugin infrastructure.