-
Notifications
You must be signed in to change notification settings - Fork 690
docs: Fixing Sphinx errors casued by structural problems #3152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kristen Kelleher <[email protected]>
Signed-off-by: Kristen Kelleher <[email protected]>
Signed-off-by: Kristen Kelleher <[email protected]>
WalkthroughDocumentation-only updates: header levels adjusted in health_check.md; hidden_toctree.rst updated to add/remove/reorder guide entries; index.rst updated to include new navigation links for Kubernetes deployment and developer guides. No code or behavior changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/guides/health_check.md (1)
23-25: Consider adding language specifiers to code blocks.The curl command blocks should specify 'bash' or 'shell' as the language for better syntax highlighting.
-``` +```bash curl -s localhost:8080/live -q | jq```diff -``` +```bash curl -v localhost:8080/health -q | jqAlso applies to: 46-48 </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used**: Path: .coderabbit.yaml **Review profile**: CHILL **Plan**: Pro <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 406c4d4e874ad1002b3fad9d06caf8ada5706b0e and d05f128638a7bd34f6926d81a60a0393999f038d. </details> <details> <summary>📒 Files selected for processing (3)</summary> * `docs/guides/health_check.md` (2 hunks) * `docs/hidden_toctree.rst` (1 hunks) * `docs/index.rst` (2 hunks) </details> <details> <summary>🧰 Additional context used</summary> <details> <summary>🪛 markdownlint-cli2 (0.18.1)</summary> <details> <summary>docs/guides/health_check.md</summary> 23-23: Fenced code blocks should have a language specified (MD040, fenced-code-language) --- 46-46: Fenced code blocks should have a language specified (MD040, fenced-code-language) </details> </details> </details> <details> <summary>⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)</summary> * GitHub Check: Build and Test - dynamo </details> <details> <summary>🔇 Additional comments (9)</summary><blockquote> <details> <summary>docs/guides/health_check.md (4)</summary><blockquote> `21-21`: **LGTM! Header level fix improves document structure.** The change from H4 (####) to H3 (###) creates a logical heading hierarchy under the H2 "Frontend Liveness Check" section. --- `27-27`: **LGTM! Consistent header level with Example Request.** The change maintains consistency by matching the H3 level used for "Example Request" above. --- `44-44`: **LGTM! Header level fix maintains consistency.** The change from H4 to H3 matches the pattern established in the Frontend Liveness section. --- `50-50`: **LGTM! Completes the consistent header structure.** All "Example Request/Response" pairs now use H3 consistently throughout the document. </blockquote></details> <details> <summary>docs/index.rst (3)</summary><blockquote> `54-54`: **LGTM! Adds valuable navigation for detailed installation.** The "Detailed Installation Guide" entry provides users with a logical progression from the K8s quickstart to more comprehensive installation instructions. --- `74-77`: **LGTM! Well-organized developer documentation structure.** The additions create a logical flow in the Developer Guide: - Benchmarking Guide and Planner Benchmark Example are related and placed together - Logging and Health Checks provide operational guidance - All entries are appropriately positioned before the performance tuning section --- `54-54`: **All referenced docs present — no action required.** All documentation files referenced in index.rst exist at their specified paths. </blockquote></details> <details> <summary>docs/hidden_toctree.rst (2)</summary><blockquote> `27-27`: **LGTM! Proper hidden toctree organization.** The additions and reorganization properly include documentation files that need to be part of the Sphinx project structure without appearing in main navigation: - API reference and deployment guides (FluxCD, model caching) - Runtime guides (KVBM with TensorRT-LLM) - Architecture documentation (request cancellation) - SLA planner deployment moved to appropriate position Also applies to: 30-30, 33-33, 36-36, 39-39, 44-44 --- `27-27`: **All newly referenced docs exist; removal check failed** Script confirmed existence of docs/guides/dynamo_deploy/api_reference.md, docs/guides/dynamo_deploy/fluxcd.md, docs/guides/dynamo_deploy/model_caching_with_fluid.md, docs/guides/dynamo_deploy/sla_planner_deployment.md, docs/guides/run_kvbm_in_trtllm.md, and docs/architecture/request_cancellation.md. The removed-file check for docs/guides/dynamo_deploy/k8s_metrics.md failed with "/bin/bash: -c: line 26: conditional binary operator expected" — confirm the file was intentionally removed or fix the verification script. </blockquote></details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
|
/ok to test ecd75ab |
|
/ok to test 1868bbc |
Signed-off-by: Kristen Kelleher <[email protected]> Co-authored-by: nv-nmailhot <[email protected]> Signed-off-by: Jason Zhou <[email protected]>
Signed-off-by: Kristen Kelleher <[email protected]> Co-authored-by: nv-nmailhot <[email protected]>
Signed-off-by: Kristen Kelleher <[email protected]> Co-authored-by: nv-nmailhot <[email protected]> Signed-off-by: Jason Zhou <[email protected]>
Signed-off-by: Kristen Kelleher <[email protected]> Co-authored-by: nv-nmailhot <[email protected]>
Signed-off-by: Kristen Kelleher <[email protected]> Co-authored-by: nv-nmailhot <[email protected]> Signed-off-by: Jason Zhou <[email protected]>
Signed-off-by: Kristen Kelleher <[email protected]> Co-authored-by: nv-nmailhot <[email protected]> Signed-off-by: Jason Zhou <[email protected]>
Signed-off-by: Kristen Kelleher <[email protected]> Co-authored-by: nv-nmailhot <[email protected]>
Signed-off-by: Kristen Kelleher <[email protected]> Co-authored-by: nv-nmailhot <[email protected]> Signed-off-by: Kyle H <[email protected]>
Overview:
Fixing Sphinx build issues in these categories:
Details:
Where should the reviewer start?
Summary by CodeRabbit