revert: restore Dockerfile.vllm and build/run scripts to August 28 vers #2896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…havior This reverts changes to maintain the same build and run behaviors as before August 28 commit 82bae24. Changes: - Split Dockerfile.vllm dev target into local-dev (Dev Container) and dev (run.sh) - Add comprehensive feature matrix comparing both development targets - Remove --uid/--gid options from build.sh (now handled by local-dev target) - Remove DEV_MODE logic from run.sh (simplified workspace mounting) - Consolidate ENV variables in both targets for better maintainability - Update build.sh to use local-dev target for UID/GID mapping Signed-off-by: Keiven Chang <[email protected]>
keivenchang
requested review from
a team,
alec-flowers,
ishandhanani,
nnshah1,
ptarasiewiczNV,
richardhuo-nv,
rmccorm4 and
tanmayv25
as code owners
Contributor
Author
|
For 0.5.0, will cherry-pick from #2892 instead. |
keivenchang
deleted the
keivenchang/v0.5.0_revert-Dockerfile_build_run
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR reverts Dockerfile.vllm and build/run scripts to maintain the same build and run behaviors as before August 28 commit 82bae24. This is to maintain backward compatibility. To be directly merged to release/0.5.0.
Details:
local-dev: For VS Code/Cursor Dev Container plugin use onlydev: For command-line development with run.sh scriptWhere should the reviewer start?
Related Issues:
BUG-5501463