diff --git a/.devcontainer/README.md b/.devcontainer/README.md index d1d7fb4610..5209a483d0 100644 --- a/.devcontainer/README.md +++ b/.devcontainer/README.md @@ -91,11 +91,10 @@ Follow these steps to get your NVIDIA Dynamo development environment up and runn ### Step 1: Build the Development Container Image -Build `dynamo:latest-vllm-local-dev` from scratch from the source: -- Note that currently, `local-dev` is only implemented for `--framework VLLM`. +Build `dynamo:latest-vllm` from scratch from the source: ```bash -./container/build.sh --target local-dev --framework VLLM +./container/build.sh --target dev --framework VLLM ``` The container will be built and give certain file permissions to your local uid and gid. diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 2f6974c1fe..7462e6ef89 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -7,7 +7,7 @@ "name": "NVIDIA Dynamo Dev Container Development", "remoteUser": "ubuntu", // Matches our container user "updateRemoteUserUID": true, // Updates the UID of the remote user to match the host user, avoids permission errors - "image": "dynamo:latest-vllm-local-dev", // Use the latest VLLM local dev image + "image": "dynamo:latest-vllm", // Use the latest VLLM local dev image "runArgs": [ "--gpus=all", "--network=host", diff --git a/container/Dockerfile.vllm b/container/Dockerfile.vllm index 59665109a2..a305300f98 100644 --- a/container/Dockerfile.vllm +++ b/container/Dockerfile.vllm @@ -294,7 +294,7 @@ CMD [] # Use this stage when you need a full development environment with additional # tooling beyond the base runtime image. -FROM runtime AS local-dev +FROM runtime AS dev # Install utilities RUN apt-get update -y && \ diff --git a/container/build.sh b/container/build.sh index 793ab866d6..2117a3d639 100755 --- a/container/build.sh +++ b/container/build.sh @@ -465,7 +465,7 @@ fi # Add NIXL_REF as a build argument BUILD_ARGS+=" --build-arg NIXL_REF=${NIXL_REF} " -if [[ $TARGET == "local-dev" ]]; then +if [[ $TARGET == "dev" ]]; then BUILD_ARGS+=" --build-arg USER_UID=$(id -u) --build-arg USER_GID=$(id -g) " fi