diff --git a/lib/bindings/python/tests/test_kv_bindings.py b/lib/bindings/python/tests/test_kv_bindings.py index cfaee04c3d5f..753cb6113247 100644 --- a/lib/bindings/python/tests/test_kv_bindings.py +++ b/lib/bindings/python/tests/test_kv_bindings.py @@ -436,6 +436,7 @@ async def test_selection_service_session_binding_stream_drains_queue( async def test_selection_service_malformed_payload_raises_value_error( monkeypatch, method, payload ): + """Malformed binding inputs raise ValueError without truthy boolean coercion.""" monkeypatch.setenv("DYN_ROUTER_USE_KV_EVENTS", "false") service = SelectionService(indexer_threads=1) @@ -449,6 +450,12 @@ async def test_selection_service_malformed_payload_raises_value_error( with pytest.raises(ValueError, match="boolean"): await service.select({"token_ids": [1, 2, 3, 4], "is_eagle": "false"}) + for field in ("is_eagle", "engine_owned_mm_identity"): + with pytest.raises(ValueError, match="boolean"): + await service.upsert_worker({"worker_id": 1, field: "false"}) + with pytest.raises(ValueError, match="boolean"): + await service.patch_worker(1, {field: "false"}) + class IteratesNegative(list): def __iter__(self): return iter([-1]) diff --git a/lib/kv-router/src/services/selection/types.rs b/lib/kv-router/src/services/selection/types.rs index 2689b09a8cb2..15de398ccec8 100644 --- a/lib/kv-router/src/services/selection/types.rs +++ b/lib/kv-router/src/services/selection/types.rs @@ -328,6 +328,7 @@ pub struct WorkerRequest { pub max_num_batched_tokens: Option, pub total_kv_blocks: Option, pub stable_routing_id: Option, + #[serde(default, deserialize_with = "strict_bool")] pub is_eagle: Option, #[serde(default)] pub taints: HashSet, @@ -347,7 +348,7 @@ pub struct WorkerRequest { pub kv_event_source_mode: Option, /// The KV event source derives multimodal pad values from engine identities /// (SGLang after sgl-project/sglang#43043). Unset means a legacy source. - #[serde(default)] + #[serde(default, deserialize_with = "strict_bool")] pub engine_owned_mm_identity: Option, } @@ -363,6 +364,7 @@ pub struct WorkerPatchRequest { pub max_num_batched_tokens: Option, pub total_kv_blocks: Option, pub stable_routing_id: Option, + #[serde(default, deserialize_with = "strict_bool")] pub is_eagle: Option, pub taints: Option>, pub topology_domains: Option>, @@ -375,7 +377,7 @@ pub struct WorkerPatchRequest { pub router_hint_source_control_endpoints: Option>, #[serde(default)] pub kv_event_source_mode: Option, - #[serde(default)] + #[serde(default, deserialize_with = "strict_bool")] pub engine_owned_mm_identity: Option, }