-
Notifications
You must be signed in to change notification settings - Fork 686
feat: SLA-based Planner #1420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: SLA-based Planner #1420
Changes from 24 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
2f44c26
initial impl
tedzhouhk 1e67375
doc
tedzhouhk 609bd8a
add connector to sla-planner
tedzhouhk cf5a27b
bug fix
tedzhouhk dcfa9f6
add note
tedzhouhk cf6f825
correct note
tedzhouhk 053d703
pc
tedzhouhk d55b990
pc
tedzhouhk 5c60e46
mypy
tedzhouhk 3e8b88b
mypy
tedzhouhk 3709874
Merge branch 'main' of https://github.com/ai-dynamo/dynamo into hzhou…
tedzhouhk 6cb95b0
Merge branch 'main' into hzhou/sla_planner_v2
tedzhouhk 5d0fef6
Update docs/architecture/planner.md
tedzhouhk 0f2cd44
Merge branch 'main' of https://github.com/ai-dynamo/dynamo into hzhou…
tedzhouhk 6f69a79
stash
tedzhouhk 29380ee
Merge branch 'hzhou/sla_planner_v2' of https://github.com/ai-dynamo/d…
tedzhouhk 2aae82e
stage
tedzhouhk fa6702c
finish refactor
tedzhouhk 19d1fc5
update doc
tedzhouhk 90b1267
address PR comments
tedzhouhk cb0d218
correct interpolation
tedzhouhk 62e1328
add comment for forecasting model
tedzhouhk 94e9691
use dataclass
tedzhouhk b6f3161
better code quality
tedzhouhk 66b8402
fix init.py
tedzhouhk 52787de
fix code for debug
tedzhouhk a4acd2b
fix typo
tedzhouhk e024c59
Merge branch 'main' of https://github.com/ai-dynamo/dynamo into hzhou…
tedzhouhk 9c66f11
pc
tedzhouhk 6a9437e
Update components/planner/src/dynamo/planner/prometheus.py
tedzhouhk b08ddfd
Merge branch 'main' of https://github.com/ai-dynamo/dynamo into hzhou…
tedzhouhk 41e7d23
Update docs/architecture/planner.md
tedzhouhk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import argparse | ||
| import asyncio | ||
| import logging | ||
|
|
||
| from pydantic import BaseModel | ||
|
|
||
| from dynamo.planner.defaults import SLAPlannerDefaults | ||
| from dynamo.planner.utils.planner_core import start_sla_planner | ||
| from dynamo.runtime.logging import configure_dynamo_logging | ||
| from dynamo.sdk import async_on_start, dynamo_context, endpoint, service | ||
| from dynamo.sdk.core.protocol.interface import ComponentType | ||
| from dynamo.sdk.lib.config import ServiceConfig | ||
| from dynamo.sdk.lib.image import DYNAMO_IMAGE | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| # start planner 30 seconds after the other components to make sure planner can see them | ||
| # TODO: remove this delay | ||
| INIT_PLANNER_START_DELAY = 30 | ||
|
|
||
|
|
||
| class RequestType(BaseModel): | ||
| text: str | ||
|
|
||
|
|
||
| @service( | ||
| dynamo={ | ||
| "namespace": "dynamo", | ||
| "component_type": ComponentType.PLANNER, | ||
| }, | ||
| resources={"cpu": "10", "memory": "20Gi"}, | ||
| workers=1, | ||
| image=DYNAMO_IMAGE, | ||
| ) | ||
| class Planner: | ||
| def __init__(self): | ||
| configure_dynamo_logging(service_name="Planner") | ||
| logger.info("Starting planner") | ||
| self.runtime = dynamo_context["runtime"] | ||
|
|
||
| config = ServiceConfig.get_instance() | ||
|
|
||
| # Get namespace directly from dynamo_context as it contains the active namespace | ||
| self.namespace = dynamo_context["namespace"] | ||
| config_instance = config.get("Planner", {}) | ||
|
|
||
| self.args = argparse.Namespace( | ||
| namespace=self.namespace, | ||
| environment=config_instance.get( | ||
| "environment", SLAPlannerDefaults.environment | ||
| ), | ||
| no_operation=config_instance.get( | ||
| "no-operation", SLAPlannerDefaults.no_operation | ||
| ), | ||
| log_dir=config_instance.get("log-dir", SLAPlannerDefaults.log_dir), | ||
| adjustment_interval=config_instance.get( | ||
| "adjustment-interval", SLAPlannerDefaults.adjustment_interval | ||
| ), | ||
| max_gpu_budget=config_instance.get( | ||
| "max-gpu-budget", SLAPlannerDefaults.max_gpu_budget | ||
| ), | ||
| min_endpoint=config_instance.get( | ||
| "min-endpoint", SLAPlannerDefaults.min_endpoint | ||
| ), | ||
| decode_engine_num_gpu=config_instance.get( | ||
| "decode-engine-num-gpu", SLAPlannerDefaults.decode_engine_num_gpu | ||
| ), | ||
| prefill_engine_num_gpu=config_instance.get( | ||
| "prefill-engine-num-gpu", SLAPlannerDefaults.prefill_engine_num_gpu | ||
| ), | ||
| prometheus_endpoint=config_instance.get( | ||
| "prometheus-endpoint", SLAPlannerDefaults.prometheus_endpoint | ||
| ), | ||
| profile_results_dir=config_instance.get( | ||
| "profile-results-dir", SLAPlannerDefaults.profile_results_dir | ||
| ), | ||
| isl=config_instance.get("isl", SLAPlannerDefaults.isl), | ||
| osl=config_instance.get("osl", SLAPlannerDefaults.osl), | ||
| ttft=config_instance.get("ttft", SLAPlannerDefaults.ttft), | ||
| itl=config_instance.get("itl", SLAPlannerDefaults.itl), | ||
| load_predictor=config_instance.get( | ||
| "load-predictor", SLAPlannerDefaults.load_predictor | ||
| ), | ||
| load_prediction_window_size=config_instance.get( | ||
| "load-prediction-window-size", | ||
| SLAPlannerDefaults.load_prediction_window_size, | ||
| ), | ||
| ) | ||
|
|
||
| @async_on_start | ||
| async def async_init(self): | ||
| await asyncio.sleep(INIT_PLANNER_START_DELAY) | ||
| logger.info("Calling start_planner") | ||
| await start_sla_planner(self.runtime, self.args) | ||
| logger.info("Planner started") | ||
|
|
||
| @endpoint() | ||
| async def generate(self, request: RequestType): | ||
| """Dummy endpoint to satisfy that each component has an endpoint""" | ||
tedzhouhk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| yield "mock endpoint" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import logging | ||
| import subprocess | ||
| import tempfile | ||
|
|
||
| import yaml | ||
|
|
||
| from dynamo.sdk import service | ||
| from dynamo.sdk.lib.config import ServiceConfig | ||
| from dynamo.sdk.lib.image import DYNAMO_IMAGE | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| @service( | ||
| dynamo={ | ||
| "namespace": "dynamo", | ||
| }, | ||
| workers=1, | ||
| image=DYNAMO_IMAGE, | ||
| ) | ||
| class Prometheus: | ||
| def __init__(self): | ||
| """Initialize Frontend service with HTTP server and model configuration.""" | ||
| self.config = ServiceConfig.get_parsed_config("Prometheus") | ||
| self.process = None | ||
tedzhouhk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| logger.warning(f"Prometheus config: {self.config}") | ||
tedzhouhk marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| self.start_prometheus_server() | ||
|
|
||
| def start_prometheus_server(self): | ||
| logger.info("Starting prometheus server...") | ||
|
|
||
| self.temp_file = tempfile.NamedTemporaryFile( | ||
| mode="w", suffix=".yml", delete=False | ||
| ) | ||
| yaml.dump(self.config, self.temp_file) | ||
| self.temp_file.close() | ||
| config_path = self.temp_file.name | ||
|
|
||
| cmd = [ | ||
| "prometheus", | ||
| f"--config.file={config_path}", | ||
| ] | ||
|
|
||
| logger.info(f"Prometheus cmd: {cmd}") | ||
|
|
||
| self.process = subprocess.Popen( | ||
| cmd, | ||
| stdout=None, | ||
| stderr=None, | ||
| ) | ||
tedzhouhk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.